Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Custom flows audit #1544

Merged
merged 22 commits into from
Sep 27, 2024
Merged

Custom flows audit #1544

merged 22 commits into from
Sep 27, 2024

Conversation

alexisintech
Copy link
Member

@alexisintech alexisintech commented Sep 16, 2024 •
edited by victoriaxyz
Loading

Important

🔎 Previews:

Explanation:

This PR:

  • Retests all flows to ensure they are still properly working
  • Adds collapsible: true to codeblocks
  • Uses <CodeBlockTabs /> for the JavaScript multi-file examples
  • Ensures consistent code comments, copy, and "custom flow callout" across guides

@alexisintech alexisintech changed the title Update custom flows Custom flows audit Sep 16, 2024
@alexisintech alexisintech marked this pull request as ready for review September 17, 2024 16:31
@alexisintech alexisintech requested a review from a team as a code owner September 17, 2024 16:31
@github-actions GitHub Actions
Copy link

Hey, here’s your docs preview: https://clerk.com/docs/pr/1544

victoriaxyz
victoriaxyz reviewed Sep 24, 2024
View reviewed changes
Copy link
Contributor

@victoriaxyz victoriaxyz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Left some comments. Also, should we add docs around the difference between first versus second factor authentication strategies?

docs/custom-flows/email-password-mfa.mdx Outdated Show resolved Hide resolved
docs/custom-flows/email-password-mfa.mdx Outdated Show resolved Hide resolved
docs/custom-flows/email-password.mdx Outdated Show resolved Hide resolved
docs/custom-flows/email-password.mdx Outdated Show resolved Hide resolved
docs/custom-flows/forgot-password.mdx Outdated Show resolved Hide resolved
docs/custom-flows/passkeys.mdx Outdated Show resolved Hide resolved
@victoriaxyz victoriaxyz self-requested a review September 26, 2024 21:14
@alexisintech alexisintech merged commit 3ccad5e into main Sep 27, 2024
4 checks passed
@alexisintech alexisintech deleted the aa/DOCS-9010 branch September 27, 2024 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@victoriaxyz victoriaxyz victoriaxyz approved these changes

Assignees
No one assigned
Labels
deploy-preview
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alexisintech @victoriaxyz