Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add chrome extension docs #1004
base: main
Are you sure you want to change the base?
Add chrome extension docs #1004
Changes from 1 commit
f4d174f
c27b3e1
a22cca2
e7a9f16
8c51fdf
b914288
b2fad09
db6027b
83e0483
aa02331
59e44e8
c0ef337
ceb71e8
943590c
8024c9d
fd48074
242ce0b
51398e5
49c533a
17111e0
b1f74c3
3588098
6adff65
6c97c1e
5d652e7
6684ccf
cc14996
d651d05
4b63d23
5c0c349
be0ca47
d971ef7
a1e05b9
8a6f064
39af324
2c7379b
d8dc758
ba77e0f
590d75e
f17541b
f861d5f
9fbf02d
dbd2302
4d3071c
eadfb61
120dbb5
cd87cd8
64772df
c54abe0
83ff88f
df1b818
7b7b529
875aa5d
f4cde8c
bbd91fe
5ef1bb9
e776fac
4ec3dec
e5a046a
5061b55
ea5cfcc
386ccb9
52db88d
8ca5900
2b7d8ae
10d1eb2
f74b3ea
923154a
2c6017c
7a565b9
7850e3e
157cf1a
dd3e8ab
50a41ae
7b89c8f
6d56db7
da54b75
26642f4
721d1cd
c054bbc
57d1519
d755146
b48ecb1
a388961
a48e39c
cce04fb
ba2c35f
f7ee192
55ab3d8
83afe12
3c34ad2
3b7982a
875c283
634621e
6709d63
e56dcd3
f69cf41
efcbd36
9c6e85e
9e426c2
c67ec0f
2ea53a4
6cb0fe0
39c4cf7
3880bee
2fbcf3c
eb07fd7
12bf683
053c24d
f9c2aca
d9e7766
d970449
8b868a1
97658b0
994066d
996e861
b8ee697
27620b9
ba6ce6e
3ae5a8e
d6b95df
9619163
1b6eeaa
30c6640
184bee0
bbdfd62
8d646a8
43e2a8e
8f832b9
4ad9621
8cbf1dd
1e8580b
ff92b58
ad02c0e
cca64a3
da4d634
4a7832b
dba549a
f271e01
7cdb2cf
abad693
6fc9ec8
76205d3
b089102
9a399f7
1481f89
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@clerk/clerk-js
package from our CDN. The Chrome Extension SDK bundles the @clerk/clerk-js and does not load it from a remote source.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure what action is meant to be taken here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Its a suggested edit for line 84. We don't hot load clerk-js with the Chrome Extension SDK -- its bundled.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
so in the Are you using remote code? box, you would like the user to write "Clerk has had limited reports that Google may reject the extension as there is code for other Clerk SDKs that loads the @clerk/clerk-js package from our CDN. The Chrome Extension SDK bundles the @clerk/clerk-js and does not load it from a remote source."
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would like to advice them that Google might say something, and give them the information to pass on to Google. I'm not really sure they need to do it right away -- checking that box makes it harder to get approved so better off not unless you get rejected for that reason and need to explain it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like this was missed @alexisintech