Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add chrome extension docs #1004

Open
wants to merge 146 commits into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
146 commits
Select commit Hold shift + click to select a range
f4d174f
Added Chrome Extension quickstart draft
royanger May 8, 2024
c27b3e1
Scaffolded Chrome Extension section with Overview and Add React Route…
royanger May 8, 2024
a22cca2
Added first draft of react router guide
royanger May 8, 2024
e7a9f16
update copy for chrome extension QS
alexisintech May 9, 2024
8c51fdf
Update docs/quickstarts/chrome-extension.mdx
alexisintech May 9, 2024
b914288
Update docs/quickstarts/chrome-extension.mdx
alexisintech May 9, 2024
b2fad09
Update docs/quickstarts/chrome-extension.mdx
alexisintech May 10, 2024
db6027b
Added syncsessionwithtab, deployment pages, added content for all pages
royanger May 17, 2024
83e0483
Updated manifest to new format, minor cleanup of some issues
royanger May 17, 2024
aa02331
Added `permission` to syncSessionWithTab guide
royanger May 17, 2024
59e44e8
Apply suggestions from code review
royanger May 17, 2024
c0ef337
guide updates
alexisintech May 22, 2024
ceb71e8
update react router guide
alexisintech May 22, 2024
943590c
update overview
alexisintech May 22, 2024
8024c9d
Updated copy, added link from overview to deployment
royanger Jun 28, 2024
fd48074
(wip) Adding more details to auth options, more deployment info
royanger Jul 4, 2024
242ce0b
First draft rewrite of the Chrome Extension Quickstart to use Plasmo …
royanger Jul 20, 2024
51398e5
Minor edits
royanger Jul 22, 2024
49c533a
Updated Chrome Extension React Router guide
royanger Jul 24, 2024
17111e0
Updated Chrome Extension react router guide
royanger Jul 24, 2024
b1f74c3
Updated the `syncSessionWithTab` guide
royanger Jul 24, 2024
3588098
Removed unneeded section from Quickstart
royanger Jul 25, 2024
6adff65
Updated the Chrome Extension doc for configuring CRD Id
royanger Jul 26, 2024
6c97c1e
Updated deployment guide, other small updates
royanger Jul 26, 2024
5d652e7
edit deploy guide
alexisintech Aug 1, 2024
6684ccf
Merge branch 'main' into roy/add-chrome-extension-docs
alexisintech Aug 1, 2024
cc14996
format deploy guide
alexisintech Aug 1, 2024
d651d05
format overview
alexisintech Aug 1, 2024
4b63d23
remove unnecessary copy from deployment guide
alexisintech Aug 1, 2024
5c0c349
update and format quickstart
alexisintech Aug 1, 2024
be0ca47
update deployment guide
alexisintech Aug 1, 2024
d971ef7
update deployment guide name in sidenav
alexisintech Aug 1, 2024
a1e05b9
fix formatting for deployment guide
alexisintech Aug 1, 2024
8a6f064
Merge branch 'main' into roy/add-chrome-extension-docs
alexisintech Aug 14, 2024
39af324
Merge branch 'main' into roy/add-chrome-extension-docs
bradlc Sep 4, 2024
2c7379b
General cleanup; apply formatting
bradlc Sep 4, 2024
d8dc758
fix links
bradlc Sep 4, 2024
ba77e0f
Hugging Face OAuth Guide follow-up review (#1505)
alexisintech Sep 4, 2024
590d75e
Add Clerk + InstantDB integration guide (#1512)
stopachka Sep 5, 2024
f17541b
Remove OAuth references from custom SAML connection docs (#1514)
LauraBeatris Sep 5, 2024
f861d5f
Fix typos in astro.mdx (#1518)
lorenzolewis Sep 6, 2024
9fbf02d
Move sections about Account Portal hosted pages to AP overview; refre…
alexisintech Sep 6, 2024
dbd2302
add instructions to sign up on localhost (#1515)
mwickett Sep 6, 2024
4d3071c
Update card logos (#1520)
bradlc Sep 9, 2024
eadfb61
Change "Cypress" to "Playwright" in Playwright docs (#1524)
stilt0n Sep 9, 2024
120dbb5
Property 'biometryType' does not exist on type 'LocalCredentialsRetur…
MathieuNls Sep 9, 2024
cd87cd8
Emphasize importance of `authorizedParties` argument use on the backe…
jescalan Sep 9, 2024
64772df
Update custom-signup-signin-pages.mdx (#1523)
sherlocked6 Sep 9, 2024
c54abe0
[fix] change function declaration to export default (#1525)
victoriaxyz Sep 10, 2024
83ff88f
[fix] change spelling from ap to app (#1526)
victoriaxyz Sep 10, 2024
df1b818
TanStack Start SDK (#1495)
octoper Sep 11, 2024
7b7b529
[fix] Refactor sign up and sign in options doc (#1517)
victoriaxyz Sep 11, 2024
875aa5d
chore: Add ClerkProvider properties (#1510)
LekoArts Sep 12, 2024
f4cde8c
Update Playwright docs (#1527)
victoriaxyz Sep 12, 2024
bbd91fe
[fix] update doc for custom sign-out flow and code examples for next.…
victoriaxyz Sep 12, 2024
5ef1bb9
Remove typo in guides overview (#1534)
gopinav Sep 13, 2024
e776fac
docs(astro): Add `<UserProfile />` custom pages and links section (#1…
wobsoriano Sep 13, 2024
4ec3dec
docs-9205: change appearance prop color from red to purple (#1536)
victoriaxyz Sep 13, 2024
e5a046a
feat: Native Apple sign in (#1294)
gkats Sep 16, 2024
5061b55
Update Reset a user's MFA instructions to use Dashboard over BAPI (#1…
alexisintech Sep 16, 2024
ea5cfcc
docs: fix typo in set-up-preview-environment.mdx (#1539)
yamcodes Sep 16, 2024
386ccb9
Correct broken link (#1541)
skullface Sep 16, 2024
52db88d
(/quickstarts/nextjs) Mention use of Account Portal (#1533)
alexisintech Sep 16, 2024
8ca5900
Update Staging guides: support subdomains over buying separate domain…
alexisintech Sep 16, 2024
2b7d8ae
iOS: Guide - Sign in with Apple (#1397)
mikepitre Sep 16, 2024
10d1eb2
Clarify how to integrate Account Portal into an app (#1542)
alexisintech Sep 17, 2024
f74b3ea
Change appearance prop examples to not use red as primary color & use…
victoriaxyz Sep 17, 2024
923154a
Add `track` prop to dashboard link in Next.js Quickstart (#1547)
bradlc Sep 17, 2024
2c6017c
Add example on defining Clerk keys per tenant from `clerkMiddleware` …
LauraBeatris Sep 17, 2024
7a565b9
(/quickstarts/remix) Remove unnecessary code from examples; add run p…
alexisintech Sep 17, 2024
7850e3e
Update invitations (user and organizations); update custom flow for u…
alexisintech Sep 17, 2024
157cf1a
Update code example for deleting a user (#1548)
alexisintech Sep 18, 2024
dd3e8ab
fix: Step 7 & 8 of Neon integration guide (#1552)
zeguillen Sep 19, 2024
50a41ae
update advanced guides with warnings on when and how to use (#1549)
victoriaxyz Sep 19, 2024
7b89c8f
feat: Improve ClerkProvider docs (#1553)
LekoArts Sep 20, 2024
6d56db7
Add callout about Clerk auto-deleting empty organizations (#1550)
alexisintech Sep 20, 2024
da54b75
Update organization-profile.mdx (#1557)
jasonaw98 Sep 24, 2024
26642f4
Move password hasher info from BAPI docs to Clerk docs (#1551)
alexisintech Sep 24, 2024
721d1cd
add run instructions to quickstarts (#1545)
mwickett Sep 24, 2024
c054bbc
Update method signature in iOS Sign in with Apple guide (#1558)
mikepitre Sep 24, 2024
57d1519
docs: update Spotify social connection guide (#1559)
kduprey Sep 24, 2024
d755146
Add info about how to access SessionWithActivities object (#1543)
alexisintech Sep 26, 2024
b48ecb1
Adding Community SolidJS SDK to docs (#1563)
JacobMGEvans Sep 26, 2024
a388961
docs(astro): Add custom menu items examples for Astro (#1519)
wobsoriano Sep 26, 2024
a48e39c
docs(astro): Update unstyled components custom usage (#1556)
wobsoriano Sep 26, 2024
cce04fb
Update shadcn-ui.mdx (#1561)
NatGlass Sep 26, 2024
ba2c35f
add note about unlimited memberships (#1568)
victoriaxyz Sep 27, 2024
f7ee192
remove return from middleware and fix syntax highlighting (#1566)
victoriaxyz Sep 27, 2024
55ab3d8
Clarifying which string is a placeholder in our file upload examples …
izaaklauer Sep 27, 2024
83afe12
Documenting that `uploaderUserId` is optional when uploading organiza…
izaaklauer Sep 27, 2024
3c34ad2
update fastify doc and quickstart (#1555)
victoriaxyz Sep 27, 2024
3b7982a
Add pages related to Sign-up mode Restricted (#1562)
kostaspt Sep 27, 2024
875c283
Custom flows audit (#1544)
alexisintech Sep 27, 2024
634621e
update variable names (#1567)
victoriaxyz Sep 27, 2024
6709d63
Update sync-data.mdx (#1564)
LoicCol Sep 27, 2024
e56dcd3
Introduce Coinbase Wallet web3 provider and authentication strategy (…
chanioxaris Sep 30, 2024
f69cf41
Add documentation for Playwright helpers (#1529)
anagstef Sep 30, 2024
efcbd36
man -> meddler (#1573)
jescalan Sep 30, 2024
9c6e85e
Add Python to docs (#1565)
alexisintech Sep 30, 2024
9e426c2
Add Clerk Express SDK docs (#1201)
EmmanouelaPothitou Sep 30, 2024
c67ec0f
Express SDK docs followup review (#1579)
alexisintech Sep 30, 2024
2ea53a4
Introduce new Web3 authentication section and Coinbase Wallet page (#…
chanioxaris Oct 1, 2024
6cb0fe0
fix clerkstage.dev link in restrictions.mdx (#1580)
astrotars Oct 1, 2024
39c4cf7
add example sections to /sign-up/sign-up and /sign-in/sign-in (#1572)
alexisintech Oct 1, 2024
3880bee
(/playwright) Fix copy errors (#1581)
alexisintech Oct 1, 2024
2fbcf3c
Add new default role setting docs (#1584)
mzhong9723 Oct 1, 2024
eb07fd7
(/authentication-flows) Fix broken link (#1583)
alexisintech Oct 2, 2024
12bf683
PR-1584 followup review from docs team (#1586)
alexisintech Oct 2, 2024
053c24d
Added Finnish language to the supported languages list. (#1585)
theisoj Oct 2, 2024
f9c2aca
(/basic-rbac) add middleware, reorg and refactor copy (#1560)
victoriaxyz Oct 3, 2024
d9e7766
(/quickstarts/javascript) fix spelling (#1593)
victoriaxyz Oct 3, 2024
d970449
(/localization) Add JS example; update list of supported locales (#1587)
alexisintech Oct 3, 2024
8b868a1
Update 'Delete MFA' > 'Reset MFA' (#1592)
alexisintech Oct 3, 2024
97658b0
update navigation instructions for new sso connections page in clerk …
alexisintech Oct 3, 2024
994066d
docs(express): Start de-emphasizing usage of `getAuth` (#1595)
wobsoriano Oct 3, 2024
996e861
Clarify usage of system permissions on the server-side (#1594)
LauraBeatris Oct 3, 2024
b8ee697
(/deploy-to-vercel) Add section about deploying a Vercel app to produ…
alexisintech Oct 4, 2024
27620b9
(chore) server side --> server-side; client side --> client-side (#1597)
alexisintech Oct 4, 2024
ba6ce6e
Align SSO connection pages with Dashboard terminology (#1596)
alexisintech Oct 4, 2024
3ae5a8e
Update Microsoft OAuth guide; align copy about development vs product…
alexisintech Oct 4, 2024
d6b95df
`.dev` → `.com` (#1605)
skullface Oct 7, 2024
9619163
Update localizations docs (#1604)
NikitaRadzkov Oct 7, 2024
1b6eeaa
update quickstart
royanger Sep 18, 2024
30c6640
Updated quickstart based on SDK changes and to improve experience
royanger Oct 8, 2024
184bee0
Converted syncSessionWithTab to Sync Host, other updates, stub for cr…
royanger Oct 8, 2024
bbdfd62
Added page for createClerkClient
royanger Oct 8, 2024
8d646a8
Updates to the Chrome Extension deployment guide
royanger Oct 8, 2024
43e2a8e
Minor typo and grammar fix
royanger Oct 10, 2024
8f832b9
Swap from PLASMO_PUBLIC_CLERK_SYNC_HOST to PLASMOST_PUBLIC_SYNC_HOST …
royanger Oct 10, 2024
4ad9621
Moved __unstable_createClerkClient to createClerkClient
royanger Oct 10, 2024
8cbf1dd
added clarifying comment
royanger Oct 10, 2024
1e8580b
Merge branch 'main' into roy/add-chrome-extension-docs
alexisintech Oct 11, 2024
ff92b58
Docs review
alexisintech Oct 17, 2024
ad02c0e
Merge branch 'main' into roy/add-chrome-extension-docs
alexisintech Oct 17, 2024
cca64a3
Update docs/deployments/deploy-chrome-extension.mdx
royanger Oct 21, 2024
da4d634
Update docs/quickstarts/chrome-extension.mdx
royanger Oct 21, 2024
4a7832b
Update docs/references/chrome-extension/configure-consistent-crx-id.mdx
royanger Oct 21, 2024
dba549a
Update docs/references/chrome-extension/add-react-router.mdx
royanger Oct 21, 2024
f271e01
Apply suggestions from code review
royanger Oct 21, 2024
7cdb2cf
Update link in sync-host.mdx
royanger Oct 22, 2024
abad693
Update link in sync-host.mdx
royanger Oct 22, 2024
6fc9ec8
Update docs/references/chrome-extension/configure-consistent-crx-id.mdx
royanger Oct 23, 2024
76205d3
Apply suggestions from code review
royanger Oct 23, 2024
b089102
apply suggestions from code review
alexisintech Oct 23, 2024
9a399f7
Update docs/references/chrome-extension/create-clerk-client.mdx
alexisintech Oct 24, 2024
1481f89
Update docs/references/chrome-extension/create-clerk-client.mdx
alexisintech Oct 24, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion docs/components/clerk-provider.mdx
Original file line number Diff line number Diff line change
Expand Up @@ -232,7 +232,7 @@ The `<ClerkProvider>` component must be added to your React entrypoint.
- `syncHost`
- `string`

**Chrome Extension only** To enable, pass the URL of the web application that the extension will sync the authentication state from. See the [dedicated guide](/docs/references/chrome-extension/sync-host-configuration) for more information.
**Chrome Extension only** To enable, pass the URL of the web application that the extension will sync the authentication state from. See the [dedicated guide](/docs/references/chrome-extension/sync-host) for more information.

---

Expand Down
110 changes: 52 additions & 58 deletions docs/deployments/deploy-chrome-extension.mdx
Original file line number Diff line number Diff line change
@@ -1,79 +1,73 @@
---
title: Deploy a Chrome Extension
description: Learn how to deploy a Chrome Extension with Clerk.
title: Deploy a Chrome Extension to production
description: Learn how to deploy a Chrome Extension to production with Clerk.
---

## Create a production instance
royanger marked this conversation as resolved.
Show resolved Hide resolved

For Clerk production instances, there must be a domain associated with the instance. Even though there may not be a web application associated with the Chrome Extension, a domain is still required. Follow the [guide on deploying your Clerk app to production](/docs/deployments/overview).
For Clerk production instances, there must be a domain associated with the instance. Even though there may not be a web application associated with your Chrome Extension, a domain is still required. Follow the [guide on deploying your Clerk app to production](/docs/deployments/overview).

## Add production domain to `host_permissions`

`host_permissions` allows you to specify which hosts, or websites, will have permission to sync auth state with your application. It accepts an array, allowing you to add more than one host.

<Steps>
### Set your Clerk API keys

Create an `.env.production` file.

<SignedIn>
Add the following keys to your `.env.production` file. These keys can always be retrieved from the [API Keys](https://dashboard.clerk.com/last-active?path=api-keys) page of your Clerk Dashboard.
</SignedIn>
## Update your `.env.production` file

<SignedOut>
1. Navigate to the [Clerk Dashboard](https://dashboard.clerk.com/last-active?path=api-keys).
1. At the top of the Dashboard, ensure that your production instance is selected.
1. In the navigation sidebar, select **API Keys**.
1. In the **Quick Copy** section, select **Chrome Extension** and copy your Clerk publishable and frontend API key.
1. Paste your keys into your `.env.production` file.
1. If you are using the Sync Host feature, follow the [Sync Host Configuration](/docs/references/chrome-extension/sync-host-configuration) guide to correctly configure your `syncHost` prop on `<ClerkProvider>` and the `host_permissions` in your `package.json` or `manifest.json`
1. If you followed our guide then your `package.json` will add `/*` to the end. Otherwise ensure that you add that yourself at this stage.
<SignedIn>
Add your publishable and frontend API keys for your Clerk production instance to your `.env.production` file. These keys can always be retrieved from the [API Keys](https://dashboard.clerk.com/last-active?path=api-keys) page of your Clerk Dashboard. If you are using [the Sync Host feature](/docs/references/chrome-extension/sync-host), you will also need to set the `PLASMO_PUBLIC_SYNC_HOST` environment variable. The value should be the domain your web app's production server runs on. For example, `https://clerk.com`.
royanger marked this conversation as resolved.
Show resolved Hide resolved
</SignedIn>

<SignedOut>
1. At the top of the Clerk Dashboard, in the instance selection dropdown, ensure that your production instance is selected.
1. Navigate to the [**API Keys**](https://dashboard.clerk.com/last-active?path=api-keys) page.
1. In the **Quick Copy** section, select **Chrome Extension** and copy your Clerk publishable and frontend API key.
1. Paste your keys into your `.env.production` file.
1. If you are using [the Sync Host feature](/docs/references/chrome-extension/sync-host), you will also need to set the `PLASMO_PUBLIC_SYNC_HOST` environment variable. The value should be the domain your web app's production server runs on. For example, `https://clerk.com`.
royanger marked this conversation as resolved.
Show resolved Hide resolved

The final result should resemble the following:
</SignedOut>
The final result should resemble the following:
</SignedOut>

```env {{ filename: '.env.production' }}
PLASMO_PUBLIC_CLERK_PUBLISHABLE_KEY={{pub_key}}
CLERK_FRONTEND_API={{fapi_url}}
PLASMO_PUBLIC_SYNC_HOST=https://yourdomain.com
```
```env {{ filename: '.env.production' }}
PLASMO_PUBLIC_CLERK_PUBLISHABLE_KEY={{pub_key}}
CLERK_FRONTEND_API={{fapi_url}}
PLASMO_PUBLIC_SYNC_HOST=https://yourdomain.com
royanger marked this conversation as resolved.
Show resolved Hide resolved
```

### Update `package.json`
## Add production domain to `host_permissions`

> [!NOTE]
> If you followed our guide for Sync Host then you have completed this step and are using the value of the Environment Variable from `.env.production`
`host_permissions` specifies which hosts, or websites, will have permission to sync auth state with your app. It accepts an array, allowing you to add more than one host. You must add your production domain to the `host_permissions` array.

`host_permissions` allows you to specify which hosts, or websites, will have permission to sync auth state with your application. It accepts an array, allowing you to add more than one host.
> [!WARNING]
> If you are using the Sync Host feature and followed [the configuration guide](/docs/references/chrome-extension/sync-host), then you have already completed this step (the `http://$PLASMO_PUBLIC_SYNC_HOST/*` value points to your production domain.)
royanger marked this conversation as resolved.
Show resolved Hide resolved

1. Open your `manifest.json` file and add the `host_permissions` key.
1. For production, add your domain and ensure it is preceded with `https://`. For example, `https://clerk.com`. Only add the root domain and not any subdomains.
1. Add `/*` to the end of the domain
In the `package.json` file, in the `manifest` object, update the `host_permissions` array. Add your domain and ensure it is preceded with `https://`. For example, `https://clerk.com`. Only add the root domain and not any subdomains. Then, add `/*` to the end of the domain.

The following example shows how to configure `host_permissions` for production:
The following example shows how to configure `host_permissions` for production:

```json {{ filename: 'package.json' }}
{
// ... the rest of your package.json
"host_permissions": ["https://<yourdomain>/*", "https://$CLERK_FRONTEND_API/*"]
```json {{ filename: 'package.json', mark: [6] }}
{
// The rest of your package.json file
"manifest": {
"key": "$CRX_PUBLIC_KEY",
"permissions": ["cookies", "storage"],
"host_permissions": ["https://<yourdomain>/*", "$CLERK_FRONTEND_API/*"]
}
```
</Steps>
}
```

## Add the Extension's ID to your instance's `allowed_origins`
## Add the Extension's ID to your web app's `allowed_origins`

> [!WARNING]
> You will have likely added the Extension ID already, but using your development secret key. You must also add the Extension to the production instance's `allowed_origins`
> You may have already added the Extension ID to your web app's `allowed_origins` using your **development** secret key. You must repeat this step using your **production** secret key.

For web applications, Clerk requires you to set a **domain** in your Clerk Dashboard. For Chrome Extensions, the **extension ID** is used _instead_ of a domain. You must add this to your application's settings via the Backend API instead of the Clerk Dashboard.
<SignedIn>
In your terminal, paste the following command and replace the `<CHROME_EXTENSION_KEY>` with your extension's ID.
</SignedIn>

1. Navigate to the [Clerk Dashboard](https://dashboard.clerk.com/last-active?path=api-keys).
1. At the top of the Dashboard, ensure that your production instance is selected.
1. In the navigation sidebar, select **API Keys**.
1. Copy your secret key. It should begin with `sk_live_`.
1. In your terminal, paste the following command and replace `<YOUR_SECRET_KEY>` with your Clerk secret key, and the `<CHROME_EXTENSION_KEY>` with your extension's ID.
<SignedOut>
1. At the top of the Clerk Dashboard, in the instance selection dropdown, ensure that your production instance is selected.
1. Navigate to the [**API Keys**](https://dashboard.clerk.com/last-active?path=api-keys) page.
1. Copy your secret key. It should begin with `sk_live_`.
1. In your terminal, paste the following command. Replace `YOUR_SECRET_KEY` with your Clerk secret key and the `<CHROME_EXTENSION_KEY>` with your extension's ID.

The final result should resemble the following:
The final result should resemble the following:
</SignedOut>

```bash {{ filename: 'terminal' }}
curl -X PATCH https://api.clerk.com/v1/instance \
Expand All @@ -82,10 +76,10 @@ curl -X PATCH https://api.clerk.com/v1/instance \
-d '{"allowed_origins": ["chrome-extension://<CHROME_EXTENSION_KEY>"]}'
```

Running the command will add the extension's ID to your instance's `allowed_origins`.

## Submit your extension for review

1. In your application, create a new zip of `build/chrome-mv3-dev` folder. Upload this to the Chrome Web Store Developer Dashboard.
1. In the **Privacy** tab, find the **Permission justification** section. In this section, there is a **Are you using remote code?** section. You will need to indicate that you are using remote code. Clerk loads the `@clerk/clerk-js` package from a CDN and it is not included in the extension.
1. Submit for review in the Chrome Developer Dashboard.
1. In your app, create a new zip of the `build/chrome-mv3-dev` folder.
1. In the top-right of the [Chrome Web Store Developer Dashboard](https://chrome.google.com/webstore/developer/dashboard), select **Upload new package** and upload the zip file.
1. In the sidebar, select the **Privacy** tab.
1. In the **Permission justification** section, it asks **Are you using remote code?**. You will need to indicate that you are using remote code. In the **Justification** textbox, paste "Clerk loads the `@clerk/clerk-js` package from a CDN and it is not included in the extension."
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. In the Permission justification section, it asks Are you using remote code?. We have had limited reports that Google may reject the extension as there is code for other Clerk SDKs that loads the @clerk/clerk-js package from our CDN. The Chrome Extension SDK bundles the @clerk/clerk-js and does not load it from a remote source.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure what action is meant to be taken here

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Its a suggested edit for line 84. We don't hot load clerk-js with the Chrome Extension SDK -- its bundled.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so in the Are you using remote code? box, you would like the user to write "Clerk has had limited reports that Google may reject the extension as there is code for other Clerk SDKs that loads the @clerk/clerk-js package from our CDN. The Chrome Extension SDK bundles the @clerk/clerk-js and does not load it from a remote source."

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would like to advice them that Google might say something, and give them the information to pass on to Google. I'm not really sure they need to do it right away -- checking that box makes it harder to get approved so better off not unless you get rejected for that reason and need to explain it.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like this was missed @alexisintech

1. Complete the required information to submit your extension for review. To check the requirements that must be met before submitting, select **Why can't I submit?**.
12 changes: 7 additions & 5 deletions docs/manifest.json
Original file line number Diff line number Diff line change
Expand Up @@ -71,6 +71,10 @@
"title": "iOS",
"tag": "(Beta)",
"href": "/docs/quickstarts/ios"
},
{
"title": "Chrome Extension",
"href": "/docs/quickstarts/chrome-extension"
}
]
]
Expand Down Expand Up @@ -2152,17 +2156,15 @@
"href": "/docs/references/chrome-extension/add-react-router"
},
{
"title": "`Sync Host Configuration`",
"wrap": false,
"href": "/docs/references/chrome-extension/sync-host-configuration"
"title": "Sync your Chrome Extension with your web app",
"href": "/docs/references/chrome-extension/sync-host"
alexisintech marked this conversation as resolved.
Show resolved Hide resolved
},
{
"title": "`createClerkClient()`",
"wrap": false,
"href": "/docs/references/chrome-extension/create-clerk-client"
},
{
"title": "Configure a Consistent CRX Id",
"title": "Configure a consistent CRX ID",
"href": "/docs/references/chrome-extension/configure-consistent-crx-id"
}
]
Expand Down
Loading
Loading