Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump github/codeql-action from 2 to 3 #290

Merged
merged 1 commit into from
Dec 14, 2023

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Dec 13, 2023

Type

Enhancement


Description

This PR updates the version of github/codeql-action used in the GitHub Actions workflow from version 2 to 3. The update is applied to the init, autobuild, and analyze actions in the codeql.yml workflow file. This update includes the latest features and improvements from the github/codeql-action repository.


PR changes walkthrough

Relevant files                                                                                                                                 
Configuration changes
1 files
codeql.yml                                                                                                   
    .github/workflows/codeql.yml

    The `github/codeql-action` version used in the `init`,
    `autobuild`, and `analyze` actions has been updated from
    version 2 to 3.
+3/-3

User description

Bumps github/codeql-action from 2 to 3.

Release notes

Sourced from github/codeql-action's releases.

CodeQL Bundle v2.15.4

Bundles CodeQL CLI v2.15.4

Includes the following CodeQL language packs from github/codeql@codeql-cli/v2.15.4:

CodeQL Bundle

Bundles CodeQL CLI v2.15.3

Includes the following CodeQL language packs from github/codeql@codeql-cli/v2.15.3:

CodeQL Bundle

Bundles CodeQL CLI v2.15.2

Includes the following CodeQL language packs from github/codeql@codeql-cli/v2.15.2:

... (truncated)

Changelog

Sourced from github/codeql-action's changelog.

Commits
  • 3a9f6a8 update javascript files
  • cc4fead update version in various hardcoded locations
  • 183559c Merge branch 'main' into update-bundle/codeql-bundle-v2.15.4
  • 5b52b36 reintroduce PR check that confirm action can be still be compiled on node16
  • 5b19bef change to node20 for all actions
  • f2d0c2e upgrade node type definitions
  • d651fbc change to node20 for all actions
  • 382a50a Merge pull request #2021 from github/mergeback/v2.22.9-to-main-c0d1daa7
  • 458b422 Update checked-in dependencies
  • 5e0f9db Update changelog and version after v2.22.9
  • See full diff in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Bumps [github/codeql-action](https://github.com/github/codeql-action) from 2 to 3.
- [Release notes](https://github.com/github/codeql-action/releases)
- [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md)
- [Commits](github/codeql-action@v2...v3)

---
updated-dependencies:
- dependency-name: github/codeql-action
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot added the dependencies Pull requests that update a dependency file label Dec 13, 2023
Copy link

Review changes with SemanticDiff.

Copy link

what-the-diff bot commented Dec 13, 2023

PR Summary

  • Updated Code Quality Analysis Tool
    The version of the tool we use for analyzing the quality of our code (CodeQL) has been updated to Version 3. This should help us further improve the quality of our code by identifying any potential vulnerabilities or issues efficiently.

Copy link

PR Description updated to latest commit (34610e3)

Copy link

codiumai-pr-agent-free bot commented Dec 13, 2023

PR Analysis

(review updated until commit 34610e3)

  • 🎯 Main theme: Dependency update
  • 📝 PR summary: This PR updates the version of the 'github/codeql-action' dependency from version 2 to version 3 in the GitHub Actions workflow. The changes are made in the 'codeql.yml' file.
  • 📌 Type of PR: Enhancement
  • 🧪 Relevant tests added: No
  • ⏱️ Estimated effort to review [1-5]: 1, because the PR only updates a version of a dependency in the GitHub Actions workflow.
  • 🔒 Security concerns: No security concerns found

PR Feedback

  • 💡 General suggestions: The PR is straightforward and doesn't require any major changes. However, it's always a good practice to include a brief explanation of why the dependency was updated and what improvements or fixes it brings.

  • 🤖 Code feedback:
    relevant file.github/workflows/codeql.yml
    suggestion      It's a good practice to pin the version of the action to a specific commit SHA instead of a version tag for better security. This is because the version tag could be maliciously updated to point to a different commit. [important]
    relevant lineuses: github/codeql-action/init@v3

    relevant file.github/workflows/codeql.yml
    suggestion      It's a good practice to pin the version of the action to a specific commit SHA instead of a version tag for better security. This is because the version tag could be maliciously updated to point to a different commit. [important]
    relevant lineuses: github/codeql-action/autobuild@v3

    relevant file.github/workflows/codeql.yml
    suggestion      It's a good practice to pin the version of the action to a specific commit SHA instead of a version tag for better security. This is because the version tag could be maliciously updated to point to a different commit. [important]
    relevant lineuses: github/codeql-action/analyze@v3

How to use

Instructions

To invoke the PR-Agent, add a comment using one of the following commands:
/review: Request a review of your Pull Request.
/describe: Update the PR title and description based on the contents of the PR.
/improve [--extended]: Suggest code improvements. Extended mode provides a higher quality feedback.
/ask <QUESTION>: Ask a question about the PR.
/update_changelog: Update the changelog based on the PR's contents.
/add_docs: Generate docstring for new components introduced in the PR.
/generate_labels: Generate labels for the PR based on the PR's contents.
see the tools guide for more details.

To edit any configuration parameter from the configuration.toml, add --config_path=new_value.
For example: /review --pr_reviewer.extra_instructions="focus on the file: ..."
To list the possible configuration parameters, add a /config comment.

@ghost
Copy link

ghost commented Dec 13, 2023

👇 Click on the image for a new way to code review

Review these changes using an interactive CodeSee Map

Legend

CodeSee Map legend

Copy link

Persistent review updated to latest commit 34610e3

Copy link

codecov bot commented Dec 13, 2023

Codecov Report

Attention: 7 lines in your changes are missing coverage. Please review.

Comparison is base (8c8d92d) 90.22% compared to head (34610e3) 90.18%.
Report is 1 commits behind head on develop.

Files Patch % Lines
fastkml/features.py 50.00% 2 Missing ⚠️
fastkml/geometry.py 0.00% 2 Missing ⚠️
fastkml/views.py 0.00% 1 Missing and 1 partial ⚠️
fastkml/styles.py 0.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #290      +/-   ##
===========================================
- Coverage    90.22%   90.18%   -0.04%     
===========================================
  Files           39       39              
  Lines         4563     4565       +2     
  Branches       518      518              
===========================================
  Hits          4117     4117              
- Misses         357      359       +2     
  Partials        89       89              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cleder cleder merged commit 4df8fcd into develop Dec 14, 2023
44 of 48 checks passed
@cleder cleder deleted the dependabot/github_actions/github/codeql-action-3 branch December 14, 2023 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant