Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Atom Refactor code and update dependencies #275

Merged
merged 1 commit into from
Nov 20, 2023

Conversation

cleder
Copy link
Owner

@cleder cleder commented Nov 20, 2023

No description provided.

@cleder cleder linked an issue Nov 20, 2023 that may be closed by this pull request

WatermelonAI Summary

This commit and PR are focused on refactoring the code and updating dependencies for the Atom project. This will improve the overall quality of the code and ensure that it is up to date with the latest dependencies.

GitHub PRs

Click here to login to Jira
Click here to login to Confluence
Click here to login to Slack
Click here to login to Notion
Click here to login to Linear
Click here to login to Asana
fastkml is an open repo and Watermelon will serve it for free.
🍉🫶
Have you starred Watermelon?

@ghost
Copy link

ghost commented Nov 20, 2023

👇 Click on the image for a new way to code review

Review these changes using an interactive CodeSee Map

Legend

CodeSee Map legend

Copy link

what-the-diff bot commented Nov 20, 2023

PR Summary

  • Updates to .pre-commit-config.yaml

    • Removed the unimport hook for code cleanup
    • Included the pyupgrade hook, which automatically upgrades Python syntax to newer versions.
  • Modifications to fastkml/atom.py

    • The Link and _Person classes were both significantly enhanced, with new attributes and methods being added and several existing attributes became optional.
    • The Author and Contributor classes are now subclasses of _Person, and their __name__ attribute has been revised to lower case to maintain code consistency.
    • The KML to Python conversion process has been improved in the Link and _Person classes through changes in _get_kwargs method.
  • Changes in the fastkml/base.py

    • Removal of multiple helper functions, indicating a move towards more efficient or direct methods of operation.
  • Updates to fastkml/geometry.py

    • The error handling in the _get_geometry method has been enhanced to provide more detailed decodings of errors.
  • Deletion of fastkml/helpers.py

    • The helper functions might have been refactored and moved to other places in the system/software to streamline the code organization.
  • Improvements in fastkml/kml.py

    • Usage of the Author class from the atom module shows a move towards better modularity and code sharing.
  • Required updates in test files

    • The test cases have been appropriately adjusted to mirror the changes in the codebase. Notably, updates were made to use the new Author class and utilize the new class_from_string method.
  • Removal of KmlObjectMap

    • The removal of 'KmlObjectMap' from 'fastkml/types.py' might suggest a refactoring or a change in data handling strategy within the application.

@cleder cleder merged commit 2b2db5a into develop Nov 20, 2023
40 of 46 checks passed
@cleder cleder deleted the 262-refactor-atom-link-and-_person branch November 20, 2023 22:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refactor Atom Link and _Person
1 participant