Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doc-string Change #253

Merged
merged 2 commits into from
Oct 29, 2023
Merged

Doc-string Change #253

merged 2 commits into from
Oct 29, 2023

Conversation

younggentech
Copy link
Contributor

Hello! I have changed documentation. It is my first open-source contribution ever...

@watermelon-copilot-for-code-review

@what-the-diff
Copy link

what-the-diff bot commented Oct 28, 2023

PR Summary

  • Modification of the 'Link' Class in fastkml/atom.py
    The 'Link' class has seen a few important changes. One of these is an updated comment that now explains that the 'rel' attribute is used to define the type of relationship. Moreover, the class description has been adapted to clarify that each feed is only allowed one alternate per type and hreflang. These changes will facilitate better understanding and correct usage of the class in future.

@codecov
Copy link

codecov bot commented Oct 29, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (401c43b) 93.19% compared to head (60b2dc6) 93.19%.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #253   +/-   ##
========================================
  Coverage    93.19%   93.19%           
========================================
  Files           34       34           
  Lines         4790     4790           
========================================
  Hits          4464     4464           
  Misses         326      326           
Files Coverage Δ
fastkml/atom.py 100.00% <ø> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cleder cleder merged commit c60ab38 into cleder:develop Oct 29, 2023
25 of 27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants