Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add amd desktop and server #23

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add amd desktop and server #23

wants to merge 1 commit into from

Conversation

sn99
Copy link

@sn99 sn99 commented Jan 6, 2021 •
edited
Loading

@mns6070
Copy link

mns6070 commented Jan 12, 2021

Can someone merge this request? I am also on an amd processor and would like to use this feature.

phmccarty
phmccarty suggested changes Jul 2, 2021
View reviewed changes
Copy link

@phmccarty phmccarty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, there is a syntax issue with this change. See my comment inline.

src/server.c
@@ -54,11 +54,14 @@ int is_server(void)
if (c == NULL)
break;
if (strstr(buffer, "model name")) {
if (strstr(buffer, "Xeon"))
if (strstr(buffer, "Xeon")) ||
(strstr(buffer, "EPYC")))
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I presume the intended change is:

-			if (strstr(buffer, "Xeon"))
+			if (strstr(buffer, "Xeon") ||
+			    strstr(buffer, "EPYC"))

Is that correct?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phmccarty phmccarty phmccarty requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sn99 @mns6070 @phmccarty