Fatal log update #843
Merged
Fatal log update #843
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fenrus75
approved these changes
Jul 22, 2024
Signed-off-by: William Douglas <[email protected]>
bwarden
reviewed
Jul 22, 2024
autospec/build.py
Outdated
| is_clean = False | ||
| return is_clean | ||
| if fatal_buf: | ||
| fatal_buf = f"{fatal_buf}\nCannot resolve dependency name: {match.group(1)}" |
There was a problem hiding this comment.
What about making fatal_buf a list instead so we can just append to it cleanly and join with LFs when we print?
bryteise
force-pushed
the
fatal-log-update
branch
from
ed97bc8
to
37f63bf
Compare
fenrus75
approved these changes
Jul 22, 2024
print_fatal calls need to be followed up by an exit consistently and exit's need to use print_fatal before being called. Signed-off-by: William Douglas <[email protected]>
Once we know autospec is going to exit unsuccessfully, send out a hopefully useful error from print_fatal or scan the build.log one last time for useful data and add that content to an output file. This is intended to only be done in update flows and the file should be cleaned up prior to autospec being run again. Note that without a special environment variable active nothing will be written out to the file. Signed-off-by: William Douglas <[email protected]>
Add an options.conf flag for allowing builds to use mock's --short-circuit for reducing rebuild time. This change moves the feature from default enabling with no way to turn off to default disable with a configure to turn on. Signed-off-by: William Douglas <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.