This repository has been archived by the owner on Nov 26, 2024. It is now read-only.
Canvas #44
Merged
Canvas #44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lighthouse Report
|
Visualizer ReportYou can view the results here. |
Closed
claustra01
suggested changes
Aug 15, 2024
cspell.json
Outdated
| @@ -2,5 +2,5 @@ | |||
| "ignorePaths": ["node_modules/**", "*.svg"], | |||
| "version": "0.2", | |||
| "language": "en", | |||
| "words": ["NATSUMATSURI", "yatai", "Dela", "Yuji", "Syuku", "zustand", "wadaiko", "qrcode"] | |||
| "words": ["NATSUMATSURI", "yatai", "Dela", "Yuji", "Syuku", "zustand", "wadaiko", "qrcode","nobori","Garally","natsu","matsuri"] | |||
src/components/Garally/index.tsx
Outdated
| function Garally() { | ||
| return ( | ||
| <div> | ||
| {/* biome-ignore lint/a11y/useMediaCaption: <explanation> */} |
There was a problem hiding this comment.
biomeのアクセシビリティでキャプションのエラーが出るんですよね（画像でいうaltみたいな感じのをつけなければエラーが出る。）
公式によると、
<track kind="captions" {...props} />
みたいな形で開くとこのエラーは出ないそうなんだけど、言語コードも現状は特にないし、アクセシビリティの面でいうとaria-labelは追加したので、ignoreしてこのままで良いかなと思いまして。
There was a problem hiding this comment.
There was a problem hiding this comment.
ちょっと調べてみたけど、動画じゃなくて音声の時は別にtrackは無くてもよさそう。これはこのままで！
claustra01
suggested changes
Aug 15, 2024
cspell.json
Outdated
| @@ -2,5 +2,5 @@ | |||
| "ignorePaths": ["node_modules/**", "*.svg"], | |||
| "version": "0.2", | |||
| "language": "en", | |||
| "words": ["NATSUMATSURI", "yatai", "Dela", "Yuji", "Syuku", "zustand", "wadaiko", "qrcode","nobori","Garally","natsu","matsuri"] | |||
| "words": ["NATSUMATSURI", "yatai", "Dela", "Yuji", "Syuku", "zustand", "wadaiko", "qrcode","nobori","Garelly","natsu","matsuri"] | |||
There was a problem hiding this comment.
garellyはちゃんとした（？）単語なのでホワイトリストに入れなくても良いと思います
claustra01
approved these changes
Aug 15, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.