Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix update failure caused by recent AWS changes #230

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix update failure caused by recent AWS changes #230

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,3 +5,4 @@ SpecRunner.html
.grunt
*.log
.DS_Store
.idea
6 changes: 5 additions & 1 deletion src/commands/update.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -145,7 +145,11 @@ module.exports = function update(options, optionalLogger) {
},
() => logger.logStage('waiting for IAM role propagation'),
Promise
);
).then(result => {
logger.logStage('waiting for lambda resource allocation');
return waitUntilNotPending(lambda, lambdaConfig.name, awsDelay, awsRetries)
.then(() => result);
});
}
},
cleanup = function () {
Expand Down
6 changes: 3 additions & 3 deletions src/tasks/wait-until-not-pending.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,8 @@
const retry = require('oh-no-i-insist');
module.exports = function waitUntilNotPending(lambda, functionName, timeout, retries) {
module.exports = async function waitUntilNotPending(lambda, functionName, timeout, retries) {
'use strict';
await new Promise(resolve => setTimeout(resolve, timeout));

return retry(
() => {
return lambda.getFunctionConfiguration({FunctionName: functionName}).promise()
Expand All @@ -20,5 +22,3 @@ module.exports = function waitUntilNotPending(lambda, functionName, timeout, ret
Promise
);
};