Strip UTF-8 byte order marks from request body #68
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces the functionality to automatically strip UTF-8 byte order marks from the request body.
The original trouble that led to this PR is that CSV files created by Microsoft Excel put the UTF-8 byte order marks into the output file. As an example, these are the first three bytes of a file generated with Microsoft Excel:
When the body was decoded, these bytes remained, causing the first CSV field to have those unusual three bytes (comprising the
\ufeffcharacter) at the front, causing key matching based on that key to fail.