Fix bug with window scroll container #806
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
There were some issues about incorrect sorting behavior in grid list with enabled
useWindowAsScrollContainer
, for example, #577.When prop
useWindowAsScrollContainer
is set totrue
, sorting in grid list does not work properly:useWindowAsScrollContainer.bug.mp4
Solution
Such behavior is caused because of using root
html
element as scrolling container. Scrolling container's width is used for counting of new coordinates of list item during sorting.html
element has width much more, than grid list container element, new coordinates counts wrong, that's why we can see incorrect sorting behavior.This PR fixes issue with incorrect sorting by using width of grid container instead of using width of
html
element, where it's needed.The result of this fix:
useWindowAsScrollContainer.bug.fixed.mp4