Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Review reverse charge #531

Merged
merged 9 commits into from
Dec 2, 2024
Merged

Review reverse charge #531

merged 9 commits into from
Dec 2, 2024

Conversation

TropicalDog17
Copy link
Contributor

@TropicalDog17 TropicalDog17 commented Nov 20, 2024 •
edited
Loading

Summary of changes

  • Add test multi-denoms taxes
  • Add test multi-denom, with consideration to min-gas-prices
  • Add e2e test for authz

...
To be updated

Report of required housekeeping

  • Github issue OR spec proposal link
  • Wrote tests
  • Updated API documentation (client/lcd/swagger-ui/swagger.yaml)
  • Added a relevant changelog entry: clog add [section] [stanza] [message]

(FOR ADMIN) Before merging

  • Added appropriate labels to PR
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)
  • Confirm added tests are consistent with the intended behavior of changes
  • Ensure all tests pass

@TropicalDog17 TropicalDog17 marked this pull request as ready for review November 27, 2024 11:46
@StrathCole StrathCole merged commit c8d09c6 into classic-terra:strath/reverse-charge Dec 2, 2024
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@TropicalDog17 @StrathCole