Allow legacy and upstream message types #530
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Copilot reviewed 5 out of 13 changed files in this pull request and generated no suggestions.
Files not reviewed (8)
- tests/e2e/scripts/add_burn_tax_exemption_address_proposal.json: Language not supported
- custom/staking/types/codec.go: Evaluated as low risk
- custom/distribution/types/codec.go: Evaluated as low risk
- custom/auth/types/codec.go: Evaluated as low risk
- custom/slashing/types/codec.go: Evaluated as low risk
- custom/feegrant/types/codec.go: Evaluated as low risk
- custom/crisis/types/codec.go: Evaluated as low risk
- custom/authz/types/codec.go: Evaluated as low risk
|
Tested and doesn't work this way. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces several changes to enhance backward compatibility and improve test coverage in the codebase. The primary focus is on adding wrapper types for backward compatibility and implementing a new test case for message compatibility.
Backward compatibility improvements:
custom/auth/types/codec.go: Added wrapper typesLegacyStdTx,LegacyBaseAccount, andLegacyModuleAccountfor backward compatibility and registered them with the codec.custom/authz/types/codec.go: Introduced wrapper types such asLegacyMsgGrant,LegacyMsgRevoke,LegacyMsgExec, andLegacyGenericAuthorizationfor backward compatibility and registered them with the codec.custom/bank/types/codec.go: Added wrapper typesLegacyMsgSend,LegacyMsgMultiSend, andLegacySendAuthorizationfor backward compatibility and registered them with the codec.custom/crisis/types/codec.go: Created a wrapper typeLegacyMsgVerifyInvariantfor backward compatibility and registered it with the codec.custom/distribution/types/codec.go: Implemented wrapper types such asLegacyMsgSetWithdrawAddress,LegacyMsgFundCommunityPool,LegacyMsgWithdrawDelegatorReward,LegacyMsgWithdrawValidatorCommission, andLegacyCommunityPoolSpendProposalfor backward compatibility and registered them with the codec.New test case:
custom/auth/ante/fee_test.go: Added a new test caseTestLegacyAndUpstreamMsgSendCompatibilityto ensure compatibility between legacy and upstream message formats.These changes ensure that the system remains compatible with older message formats while enhancing the overall test coverage.