Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tests #472

Merged
merged 3 commits into from
May 13, 2024
Merged

Fix tests #472

merged 3 commits into from
May 13, 2024

Conversation

StrathCole
Copy link
Collaborator

Summary of changes

Fixed tests

Report of required housekeeping

  • Github issue OR spec proposal link
  • Wrote tests
  • Updated API documentation (client/lcd/swagger-ui/swagger.yaml)
  • Added a relevant changelog entry: clog add [section] [stanza] [message]

(FOR ADMIN) Before merging

  • Added appropriate labels to PR
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)
  • Confirm added tests are consistent with the intended behavior of changes
  • Ensure all tests pass

@StrathCole
Copy link
Collaborator Author

StrathCole commented May 6, 2024

To explain: The multisend does not allow multiple input entries. Also the proto import wasn't correct for dyncomm test.
I did not fix all the linting complaints in your branch though. So it won't pass tests at the moment anyway until you fixed that, too.

@phamminh0811 phamminh0811 merged commit 4d5f770 into minh/v3 May 13, 2024
17 of 22 checks passed
@phamminh0811 phamminh0811 deleted the strath/fix-tests-v3 branch May 13, 2024 10:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants