Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat/interchaintest #402

Merged
merged 48 commits into from
Feb 14, 2024
Merged

Feat/interchaintest #402

merged 48 commits into from
Feb 14, 2024

Conversation

expertdicer
Copy link
Collaborator

Summary of changes

Interchaintest orchestrates Go tests that utilize Docker containers for multiple IBC-compatible blockchains.

It allows users to quickly spin up custom testnets and dev environments to test IBC, chain infrastructures, smart contracts, etc.

  • Built-in suite of conformance tests to test high-level IBC compatibility between chain sets
  • Easily construct customized tests in highly configurable environments
  • Deployable as CI tests in production workflows

Report of required housekeeping

  • Github issue OR spec proposal link
  • Wrote tests
  • Updated API documentation (client/lcd/swagger-ui/swagger.yaml)
  • Added a relevant changelog entry: clog add [section] [stanza] [message]

(FOR ADMIN) Before merging

  • Added appropriate labels to PR
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)
  • Confirm added tests are consistent with the intended behavior of changes
  • Ensure all tests pass

@nghuyenthevinh2000
Copy link
Contributor

@fragwuerdig you should check this one, this one is for your ibc - hook, pfm

@nghuyenthevinh2000
Copy link
Contributor

I just saw a failing CI, do you guys need anything related to setting up interchain test CI?

@fragwuerdig
Copy link
Collaborator

@expertdicer @phamminh0811 - I updated the frag/foundation branch. So please pull every changes from the base branch into this branch. Thank you.

@fragwuerdig
Copy link
Collaborator

@expertdicer - please resolve remaining conflicts after merging #417 . Thanks.

fragwuerdig
fragwuerdig reviewed Jan 31, 2024
View reviewed changes
.github/workflows/interchain.yml Show resolved Hide resolved
tests/interchaintest/chain_start_test.go Show resolved Hide resolved
tests/interchaintest/helpers/cosmwams.go Outdated Show resolved Hide resolved
tests/interchaintest/ibc_hooks_test.go Outdated Show resolved Hide resolved
tests/interchaintest/ibc_hooks_test.go Show resolved Hide resolved
tests/interchaintest/ibc_pfm_terra_test.go Outdated Show resolved Hide resolved
@fragwuerdig
Copy link
Collaborator

@expertdicer - please check my comments. Thank you.

@fragwuerdig
Copy link
Collaborator

@expertdicer: please sync with base branch again if necessary. Thanks.

@nghuyenthevinh2000 nghuyenthevinh2000 mentioned this pull request Feb 4, 2024
Merged
@fragwuerdig fragwuerdig self-requested a review February 14, 2024 17:31
fragwuerdig
fragwuerdig approved these changes Feb 14, 2024
View reviewed changes
Copy link
Collaborator

@fragwuerdig fragwuerdig left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one looks good to me. From my side it's ready to merge into frag/foundation branch

@fragwuerdig fragwuerdig merged commit c125209 into classic-terra:frag/foundation Feb 14, 2024
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phamminh0811 phamminh0811 phamminh0811 left review comments

@StrathCole StrathCole StrathCole left review comments

@fragwuerdig fragwuerdig fragwuerdig approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@expertdicer @nghuyenthevinh2000 @phamminh0811 @faddat @fragwuerdig @StrathCole