-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Whitelisting (tax exemption) feature according to prop #11824 #393
Open
StrathCole
wants to merge
80
commits into
classic-terra:main
Choose a base branch
from
StrathCole:whitelisting-v1
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- several fixes for tax exemption handling
- upgrade test
- added test
9 tasks
I already adjusted this to be compatible with the upcoming v3.0.1 (sdk 0.47). Waiting for the merge to fix remaining issues. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 33 out of 48 changed files in this pull request and generated no suggestions.
Files not reviewed (15)
- client/docs/config.json: Language not supported
- client/docs/swagger-ui/swagger.yaml: Language not supported
- custom/staking/module_test.go: Evaluated as low risk
- custom/wasm/keeper/handler_plugin.go: Evaluated as low risk
- custom/auth/tx/service.go: Evaluated as low risk
- custom/auth/ante/fee.go: Evaluated as low risk
- app/app.go: Evaluated as low risk
- cmd/terrad/root.go: Evaluated as low risk
- custom/auth/ante/expected_keeper.go: Evaluated as low risk
- custom/auth/ante/fee_tax.go: Evaluated as low risk
- custom/auth/ante/integration_test.go: Evaluated as low risk
- app/modules.go: Evaluated as low risk
- custom/auth/ante/fee_test.go: Evaluated as low risk
- custom/auth/ante/ante.go: Evaluated as low risk
- app/keepers/keepers.go: Evaluated as low risk
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
alternative implementation to #388 using message types and v1 governance
Introduce zone-based tax exemption.
Zones are always tax-free internally.
Optionally they can be set to be tax-free for incoming and/or outgoing txs.
Cross-Zone transactions are always taxed, unless cross-zone exemption is also set for the zone
Report of required housekeeping
(FOR ADMIN) Before merging
Copilot Summary
This pull request introduces a new
taxexemption
module and integrates it into the existing system. The changes include adding the module's dependencies, updating the application to include the new module, and defining the upgrade handler for the new module.Integration of
taxexemption
Module:app/app.go
: Added thev9
upgrade and included theTaxExemptionKeeper
in theNewTerraApp
function. [1] [2] [3]app/keepers/keepers.go
: Imported thetaxexemption
types and keeper, added theTaxExemptionKeeper
to theAppKeepers
struct, and initialized it in theNewAppKeepers
function. [1] [2] [3] [4] [5] [6]app/modules.go
: Imported thetaxexemption
module and added it to various module lists and functions, includingappModules
,simulationModules
,orderBeginBlockers
,orderEndBlockers
, andorderInitGenesis
. [1] [2] [3] [4] [5] [6] [7] [8]Upgrade Handler:
app/upgrades/v9/constants.go
: Defined constants and theUpgrade
struct for thev9
upgrade.app/upgrades/v9/upgrades.go
: Implemented theCreateV9UpgradeHandler
function to migrate old tax exemption data to the newtaxexemption
module.Documentation Updates:
client/docs/config.json
: Added thetaxexemption
module's query swagger definitions.client/docs/swagger-ui/swagger.yaml
: Defined the API endpoints for thetaxexemption
module, including routes for listing tax exemption zones and addresses.