Fix required conditional fields #1967
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maieutiquer
force-pushed
the
fix-required-conditional-fields
branch
from
7450a56 to
4897fbc
Compare
Elorfin
requested changes
Dec 15, 2021
YanaMIvanova
force-pushed
the
fix-required-conditional-fields
branch
from
4897fbc to
823396b
Compare
Elorfin
reviewed
Jan 20, 2022
| } | ||
| } else { | ||
| return true; | ||
| } |
There was a problem hiding this comment.
else are useless, just return true; at the end of your method.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes issue #1963