Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix closing account confirmation modal #1966

Conversation

YanaMIvanova
Copy link
Contributor

Q A
Bug fix? Yes
New feature? No
BC breaks? No
Fixed issues #1964

This PR fixes issue #1964

@YanaMIvanova YanaMIvanova changed the title [Registration] fix closing account confirmation modal Fix closing account confirmation modal Dec 7, 2021
@Elorfin
Copy link
Member

Elorfin commented Dec 7, 2021

You can't just comment code and hope everything is still working.
IMO, the real problem is explained in comment above the commented code : it will throw errors if the state is mistakenly mutated.

FI, I don't reproduce your problem on my platform.

@Elorfin Elorfin closed this Dec 7, 2021
@maieutiquer
Copy link
Contributor

It's reproduced when NODE_ENV is "development", which is only set in our environment:
image

But this explains why we didn't get this error before - we recently added NODE_ENV to our env variables

If you cannot reproduce, this might also mean that it never worked for you in development mode neither

I believe mutations should print a warning, but not crash the application, or at least it should be fixed before blocking further development of features

@maieutiquer maieutiquer reopened this Dec 7, 2021
@maieutiquer maieutiquer closed this Dec 7, 2021
@Elorfin
Copy link
Member

Elorfin commented Dec 7, 2021

Whatever you set as NODE_ENV, it is overidden by webpack. https://webpack.js.org/configuration/mode/
The problem only occurs when the registration mail option is set to another value than "none".

@maieutiquer
Copy link
Contributor

Whatever you set as NODE_ENV, it is overidden by webpack. https://webpack.js.org/configuration/mode/ The problem only occurs when the registration mail option is set to another value than "none".

This seems to be the case, so what would be the solution for this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants