[Account] Required fields do not take into account conditions

[maieutiquer]

Q	A
Bug report?	yes
Version?	13.1

When a required field depends on another field's value, if the required field is not visible (because its condition is not met), then it's still required and the user cannot proceed

Currently, the administrator is forced to make all fields optional, which is blocking the testing of account creation and conditional fields, and is critical for us

[YanaMIvanova]

This is the error we get in CEP-DEV

So we try to reproduce it locally in Claroline. This is our configuration in Administration

This is the result from our configuration right before clicking on "Create an account" button

These are the errors that we get on account creation when a conditional field is mandatory, but not visible because of its parent, this seems to be related to the following issue : #1964

Similar errors appear when we try to close the confirmation modal, even before clicking on "Validate my registration"

Because of #1964 we seem to be unable to reproduce the required conditional fields bug locally

[maieutiquer]

We managed to find the source of the issue, it seems to be caused by the way validations are done, it starts working if we disable validations here:

Claroline/src/main/core/API/Validator/UserValidator.php

Line 112 in 9fd9122

if (!ArrayUtils::has($data, 'profile.'.$field['id'])) {

We believe !ArrayUtils::has($data, 'profile.'.$field['id']) is not a sufficient check now that we have conditional fields