-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactoring HAAQI to save precomputations #364
base: main
Are you sure you want to change the base?
Conversation
@jonbarker68, this is a draft of this refactoring. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #364 +/- ##
==========================================
+ Coverage 92.88% 93.80% +0.91%
==========================================
Files 43 46 +3
Lines 3921 4597 +676
==========================================
+ Hits 3642 4312 +670
- Misses 279 285 +6 ☔ View full report in Codecov by Sentry. |
The output of this refactoring is not exactly the same as previous implementation due to the different order in when random noises are generated. |
…' into 363-add-precomputations-to-haaqi
…' into 363-add-precomputations-to-haaqi
…' into 363-add-precomputations-to-haaqi
…' into 363-add-precomputations-to-haaqi # Conflicts: # clarity/evaluator/ha/pyhaaqi.py
closes #363
This is the first draft of the refactoring of HAAQI to precompute and reuse some parts of the code.
This logic can the be applied to HASPI and HASQI
Need to run a more extensive sanity test to ensure the consistency of the output compared with the old implementation
TODO: