Python #18
Open
Python #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
twagoo
approved these changes
Oct 28, 2024
There was a problem hiding this comment.
Definitely ready to be merged but I added a couple of small comments. Also as a general comment: the meta guidelines suggest using backticks to format MUST, SHOULD etc.
| Use `pip` as default package manage: | ||
|
|
||
| * 👉 `MUST` build wheels and install package from the wheel [PEP427](https://peps.python.org/pep-0427/). | ||
| * 👉 `MUST` use pytoml + [Poetry](https://python-poetry.org/docs/pyproject/) as SCM |
There was a problem hiding this comment.
I am not a Python developer. What is SCM in this context? I tried to google it and couldn't find out
| * 👉 `MUST` build wheels and install package from the wheel [PEP427](https://peps.python.org/pep-0427/). | ||
| * 👉 `MUST` use pytoml + [Poetry](https://python-poetry.org/docs/pyproject/) as SCM | ||
| * 👉 `MUST` distribute packages as wheels | ||
| * 👉 `MUST` use CLARIN's [wheel builder](https://gitlab.com/CLARIN-ERIC/docker-alpine-wheeler) for building wheels |
There was a problem hiding this comment.
Out of scope for this review but this project lacks documentation
Comment on lines
+72
to
+74
| [Python's core unittest](https://docs.python.org/3/library/unittest.html) | ||
| [Django's unittest extension](https://docs.djangoproject.com/en/4.2/topics/testing/overview/) | ||
| [Django-rest-framework unittest extension](https://www.django-rest-framework.org/api-guide/testing/) |
There was a problem hiding this comment.
These are rendered on a single line, add markup to make into a list ?
twagoo
reviewed
Oct 28, 2024
|
|
||
| ### XML processing | ||
|
|
||
| For `.xml` files processing SHOULD use [lxml](https://lxml.de/). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.