Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Resolve object for paths ending in association #134

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Resolve object for paths ending in association #134

wants to merge 1 commit into from

Conversation

domi-b
Copy link
Contributor

@domi-b domi-b commented Oct 2, 2024

References #133

Philippluca
Philippluca approved these changes Oct 2, 2024
View reviewed changes
src/main/java/ch/interlis/iox_j/validator/AttributeArray.java
// referenced objects can have oid
String oid = thisObj.getobjectoid();
String otherOid = otherObj.getobjectoid();
if (oid == null ? otherOid != null : !oid.equals(otherOid)) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PP: Sollte auch einfacher gehen.

Suggested change
if (oid == null ? otherOid != null : !oid.equals(otherOid)) {
if (!Objects.equals(oid, otherOid)) return false;

PP: Könnte auch gleich für die Refoid so gemacht werden.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Objects.equals gibt es leider erst ab Java 7 😞

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Philippluca Philippluca Philippluca approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@domi-b @Philippluca