remove numpy style function #274
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@haesleinhuepf I removed all numpy style function from interroperability file and updated the tests. Can you confirme this is ok? I will merge this today along the next release |
|
Yes, that makes sense @StRigaud! Let's think about compatibility with numpy later :-) |
haesleinhuepf
approved these changes
Oct 18, 2024
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #274 +/- ##
==========================================
+ Coverage 87.91% 87.96% +0.05%
==========================================
Files 20 20
Lines 1646 1604 -42
==========================================
- Hits 1447 1411 -36
+ Misses 199 193 -6 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #267
closes #271
I removed the numpy style
clipwhich was overwritting clesperantoclip.The other function numpy in interoperability does not overwrite their equivalent clesperanto, should we still remove them?