Fix for incorrect function signature in power() from issue #271: updated parameters and order.
#272
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… output_image, exponent)` and renamed the parameters accordingly.
haesleinhuepf
commented
Oct 16, 2024
Comment on lines
+137
to
+146
| if np.isscalar(exponent): | ||
| from ._tier1 import power | ||
|
|
||
| return power(input_image=x1, scalar=x2, output_image=out, device=x1.device) | ||
| return power(input_image=input_image, scalar=exponent, output_image=output_image, device=input_image.device) | ||
| else: | ||
| from ._tier1 import power_images | ||
|
|
||
| x2 = asarray(x2) | ||
| exponent = asarray(exponent) | ||
| return power_images( | ||
| input_image0=x1, input_image1=x2, output_image=out, device=x1.device | ||
| input_image0=input_image, input_image1=exponent, output_image=output_image, device=input_image.device |
There was a problem hiding this comment.
This logic seems broken now.
There was a problem hiding this comment.
I think it should not be in there anyway. Can we remove it @StRigaud ? I think if people wanted to call power_images, they should do it explicitly. It should not be called in case some parameters are set in a specific way.
There was a problem hiding this comment.
This was a mimic of the numpy power function, along with other numpy function in interoperability.
The question is "how far do we mimic numpy" ( we dont is a valid answer 😉 )
|
Same as for the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This message was generated by git-bob (version: 0.9.0, model: gpt-4o-2024-08-06), an experimental AI-based assistant. It can make mistakes and has limitations. Check its messages carefully.
To address issue #271, I modified the
pyclesperanto/_interoperability.pyfile by updating the function signature of thepower()function topower(input_image, output_image, exponent). I also renamed the parameters: "x1" is now "input_image", "out" is now "output_image", and "x2" is now "exponent". These changes ensure that the function will now take parameters in the correct order, aligning with the intended design.closes #271