Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Renamed the parameter "list" to "flag_list" in the exclude_labels function and updated tests. #269

Closed
wants to merge 2 commits into from

Conversation

haesleinhuepf
Copy link
Member

This message was generated by git-bob (version: 0.9.0, model: gpt-4o-2024-08-06), an experimental AI-based assistant. It can make mistakes and has limitations. Check its messages carefully.

To resolve Issue #265, the parameter "list" in the exclude_labels function in _tier3.py was renamed to "flag_list" to avoid using a protected Python keyword. Corresponding changes were made to the function's documentation and the internal call to clic._exclude_labels. Additionally, the test cases in the newly added tests/test_exclude_labels.py were updated to use "flag_list" instead of "flaglist", ensuring consistency and validating the refactor.

closes #265

@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 87.91%. Comparing base (a2dd16c) to head (30a6c99).

Files with missing lines Patch % Lines
pyclesperanto/_tier3.py 50.00% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #269   +/-   ##
=======================================
  Coverage   87.91%   87.91%           
=======================================
  Files          20       20           
  Lines        1646     1646           
=======================================
  Hits         1447     1447           
  Misses        199      199           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@StRigaud
Copy link
Member

this is an autogen file, modification is useless, sorry :D

@StRigaud StRigaud closed this Oct 16, 2024
@StRigaud StRigaud deleted the git-bob-mod-emMJADHWXl branch November 26, 2024 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rename parameter "list" of exclude_labels
3 participants