Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: implement UUID v6, v7 and v8 fake value generation #207

Merged
merged 1 commit into from
Dec 15, 2024

Conversation

LNSD
Copy link
Contributor

@LNSD LNSD commented Dec 12, 2024

This pull request includes several updates, improving documentation, adding new features, and enhancing UUID generation. The most significant changes involve updating documentation for various modules, supporting new UUID versions, and enhancing feature flag descriptions.

Documentation Improvements:

  • Enhanced feature flag descriptions in fake/src/lib.rs to include new integrations and provide clearer explanations.

UUID Enhancements:

  • Added support for UUID versions 6, 7, and 8 in fake/src/impls/uuid/mod.rs, including new structs and Dummy trait implementations for each version. [1] [2]

Feature Flag and Configuration Updates:

  • Enabled doc_cfg feature for docs.rs to improve documentation visibility for feature-gated items.
  • Added cfg_attr annotations to conditionally compile documentation for feature-gated items in fake/src/lib.rs. [1] [2] [3]

Dependency Updates:

  • Updated uuid dependency to include additional features for new UUID versions in fake/Cargo.toml.

@LNSD LNSD force-pushed the lnsd/feat-support-uuid-v7 branch from f0f98e8 to d0ab2d9 Compare December 12, 2024 22:18
@LNSD LNSD marked this pull request as ready for review December 12, 2024 22:18
@LNSD
Copy link
Contributor Author

LNSD commented Dec 12, 2024

@cksac Thank you so much for your incredible work on this project! I appreciate all the effort put in to keep everything running. Keep up the great work! 🙏🏼

@LNSD LNSD force-pushed the lnsd/feat-support-uuid-v7 branch from d0ab2d9 to 387d032 Compare December 12, 2024 22:30
@LNSD
Copy link
Contributor Author

LNSD commented Dec 13, 2024

The Clippy CI check is failing due to an issue unrelated to this PR's changes: https://github.com/cksac/fake-rs/actions/runs/12311626538/job/34406609218?pr=207#step:5:75

error: elided lifetime has a name
Error:    --> fake/src/faker/mod.rs:25:72
    |
25  |               pub fn $name$(< $($lts),* >)?($($arg:$typ),*) -> raw::$name<$locale_s> {
    |                                                                          ^ this elided lifetime gets resolved as `'a`
...
204 | /     def_fakers! {
205 | |         Digit();
206 | |         NumberWithFormat<'a>(fmt: &'a str);
    | |                          -- lifetime `'a` declared here
207 | |     }
    | |_____- in this macro invocation
    |
    = note: `-D elided-named-lifetimes` implied by `-D warnings`
    = help: to override `-D warnings` add `#[allow(elided_named_lifetimes)]`
    = note: this error originates in the macro `def_fakers` (in Nightly builds, run with -Z macro-backtrace for more info)

@LNSD LNSD force-pushed the lnsd/feat-support-uuid-v7 branch from 387d032 to ebdd3f5 Compare December 13, 2024 07:45
@cksac cksac merged commit 06ee4a6 into cksac:master Dec 15, 2024
4 of 5 checks passed
@LNSD LNSD deleted the lnsd/feat-support-uuid-v7 branch December 16, 2024 11:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants