feat: add nodeinfo 2.1 document (parallel with 2.0). #181
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ckolderup
reviewed
Jan 24, 2024
| // implementation of http://nodeinfo.diaspora.software/protocol.html | ||
| // implementation of http://nodeinfo.diaspora.software/ | ||
| // TODO: activeMonth and activeHalfyear should be dynamic, currently static | ||
| // TODO: enable override of nodeName and nodeDescription from settings |
There was a problem hiding this comment.
this will line up nicely with our eventual switch to storing more of the config in the database and setting everything up on the web on first-time run. I'll try to keep an eye out for that when we get there!
ckolderup
previously approved these changes
Jan 24, 2024
|
Yeah, agreed on that, it's not the most elegant but does the job for now like, uh, quite a few other areas of the codebase ❤️ |
ckolderup
approved these changes
Jan 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates Postmarks support for the nodeinfo specification to include additional fields added in nodeinfo 2.1 (repository and project), as well as adding some optional metadata.
As a side-note, I also sent a PR to the nodeinfo repository to add Postmarks as a Fediverse server that implements the specification, as it has for some time now (albeit 2.0 level)