fix mastodon verification with this one weird trick #149
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Oh sheesh, sorry! I would guess that it's related to it being a helper as well, maybe it's not being evaluated otherwise. Oh no sorry oh no lgtm shipit |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had a report on Mastodon that verification wasn't working; I looked into it and noticed that since I last saw it working myself that these parentheses had been removed from the main.hbs (reasonable)
@johnholdun do you have some idea why they'd be required? I took a look through the Handlebars documentation and don't really "get it". Something to do with it being a helper function instead of a local var being passed into the render?