Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Empty title fixes; formatting AP content updates #144

Merged
merged 3 commits into from
Oct 9, 2023

Conversation

jeffsikes
Copy link
Contributor

Resolution for #143

Testing

I have the site running with these changes at:

https://smooth-fish-dash.glitch.me/
https://glitch.com/edit/#!/smooth-fish-dash

Testing scenarios below. If no title is entered and not found via opengraph, title should be empty. Easiest way to do this is use an invalid URL so OpenGraph doesn't work.

  • Attempt to add bookmark without url
  • Add from website @ /add
  • Add from Bookmarklet widget @ /admin
  • Add from Multi Add import @ /admin/bookmarks
  • Edit from website @ /bookmark/{id}/edit

If no url was added on the Add or removed from Edit and then submitted:

  • Should not be allowed and browser specific required message should appear

If the title isn't added, the results should be:

  • ActivityPub outbox message includes url as the title
  • Bookmark display @ root should display url as title
  • Bookmark display @ /bookmark/{id} should display url as title
  • Bookmark display @ /bookmark/{id}/edit should NOT display url as title, it should show blank
  • Bookmark entry in XML feed @ /index.xml should display url as title
  • Atom Feed should be valid, even when title is empty (validator

In addition:

  • ActivityPub message should not have an indention on the description as viewed in Mastodon iOS, Ice Cubes, Ivory, Mona and Elk.
  • ActivityPub link (title/url) in the content should have the privacy attributes and when clicked, open in a new window

Pull request incoming.

src/util.js Outdated Show resolved Hide resolved
@ckolderup
Copy link
Owner

Thanks so much, and I appreciate the paired issues/PRs despite my lack of CONTRIBUTING.md (which is my next task once I get past triaging incoming stuff!)

@ckolderup ckolderup merged commit 0522da2 into ckolderup:main Oct 9, 2023
1 check passed
@jeffsikes jeffsikes deleted the issue-empty-title branch October 9, 2023 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants