Allowed for linking FocusTracker instances together and propagate the focus state #17206
+1,351
−156
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oleq
changed the title
…despite a pending blur timeout.
…nt and handle its focus interactions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Suggested merge commit message (convention)
Fix (ui): The dropdown menu component should not cause an editor blur if used in a
BalloonToolbarwhile the user hovers a nested menu.Feature (utils): Made
FocusTrackerextendable with otherFocusTrackerinstances to allow logical focus tracking across separate DOM sub-trees.Additional information
Closes https://github.com/cksource/ckeditor5-commercial/issues/6633.
Comes with https://github.com/cksource/ckeditor5-commercial/pull/6672
TODOs:
FT#_labeldebug lines from features (after QA)