Add missing editor.destroy
calls to tests
#17136
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Suggested merge commit message (convention)
Tests: Add missing
editor.destroy
calls to tests.Tests: Add
await
to someeditor.destroy
calls.Additional information
Make sure that new tests are not executed before destroying the previous instance of editor. It may improve stability of the tests.
I adjusted a few destroy methods to prevent crashes while unmounting an editor without attached editable. It should not affect production code logic.
https://github.com/ckeditor/ckeditor5/pull/17136/files#diff-08c4a50a4e3011f22016b07e32ee0247c3f16921b60f4f97325370ea52a83301R141-R144
https://github.com/ckeditor/ckeditor5/pull/17136/files#diff-3137b53b3f401a6509b1d23b4181c0a926b246478b0705f955beb96ad836bad3R102-R104
https://github.com/ckeditor/ckeditor5/pull/17136/files#diff-6b59c13c57494bcace212545dcf111d9228cdc75359ff47007819627bb4449bbR96-R98