-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add instructions for the UMD build to the Quick start
guide
#17028
Conversation
Please sync this with what @gorzelinski started to prepare in the cloud branch. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. We must keep in mind Melman sync for this, too.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added a few comments.
@gorzelinski is this similar to what you have on your branch? I feel we are touching this from different angles, but I'm not sure. |
Here's a table of contents of the vanilla js cloud quick start on the epic branch. There is an "Installing CKEditor 5 from CDN" section where I describe the usage with global variables and UMD modules. The "Installing premium features from CDN" is the same but for premium features. The "Advanced setup with import maps" section contains the setup with import maps and ES Modules (for both - open-source and premium features). So, the sections are similar. However, nowhere in the guide do I mention "build," "UMD," or "ES modules" directly. |
Co-authored-by: Mateusz Gorzeliński <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Co-authored-by: Mateusz Gorzeliński <[email protected]>
Suggested merge commit message (convention)
Docs: Add instructions for the UMD build to the
Quick start
guide.Additional information
For example – encountered issues, assumptions you had to make, other affected tickets, etc.