Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Docs] Using bundlers to bundle CKEditor 5 #17016

Closed
wants to merge 4 commits into from

Conversation

filipsobol
Copy link
Member

Suggested merge commit message (convention)

Docs: Add Using bundlers to bundle CKEditor 5 document.


Additional information

For example – encountered issues, assumptions you had to make, other affected tickets, etc.

@filipsobol filipsobol changed the title Docs add using bundlers section [Docs] Using bundlers to bundle CKEditor 5 Aug 30, 2024
godai78
godai78 previously approved these changes Aug 30, 2024
@godai78
Copy link
Contributor

godai78 commented Aug 30, 2024

We may consider pushing Vite and esbuild down, as they are just links saying "do nothing else".

@filipsobol filipsobol changed the base branch from master to stable August 30, 2024 13:29
@filipsobol filipsobol dismissed godai78’s stale review August 30, 2024 13:29

The base branch was changed.

@filipsobol filipsobol changed the base branch from stable to master August 30, 2024 13:29
@filipsobol
Copy link
Member Author

We may consider pushing Vite and esbuild down, as they are just links saying "do nothing else".

If anyone uses this guide to pick a bundler, it'd be better if they choose Vite or esbuild, so I'd prefer them on top.

@filipsobol
Copy link
Member Author

I made a new PR targeting the stable branch - #17019.

@filipsobol filipsobol closed this Aug 30, 2024
@filipsobol filipsobol deleted the docs-add-using-bundlers-section branch August 30, 2024 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants