Drag-and-drop preview is blackened when using the block balloon. #15112
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
niegowski
reviewed
Oct 3, 2023
| * Check: https://github.com/ckeditor/ckeditor5/issues/15085 | ||
| */ | ||
| if ( env.isiOS ) { | ||
| preview.style.backgroundColor = computedStyle.getPropertyValue( '--ck-color-base-background' ); |
There was a problem hiding this comment.
I'm not sure if checking this CSS property is enough. As I can see it's set only on the editable of the classic editor, but the custom preview is used only in the balloon block editor so most probably that property would not be set properly.
My another doubt is whether content dragged out from a table cell with some dark background.
|
In the first iteration, I would release a white background fix, to not provide such a bad experience at the first release (still for a very low % of users). @illia-stv test how it works with tables that have background. If it's not confusing, I would go with the current scope. |
arkflpc
force-pushed
the
ck/15085-preview-is-blackened-when-using-the-block-balloon
branch
from
8c924a6
to
c462115
Compare
arkflpc
approved these changes
Oct 4, 2023
arkflpc
deleted the
ck/15085-preview-is-blackened-when-using-the-block-balloon
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Suggested merge commit message (convention)
Fix (clipboard): Drag and drop preview should not have black background on iOS. Closes #15085.
Additional information
For example – encountered issues, assumptions you had to make, other affected tickets, etc.