Fix triple click issue in paragraph with widget #15011
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arkflpc
approved these changes
Sep 20, 2023
filipsobol
reviewed
Sep 20, 2023
filipsobol
approved these changes
Sep 20, 2023
niegowski
requested changes
Sep 20, 2023
niegowski
requested changes
Sep 20, 2023
Comment on lines
219
to
221
| if ( domEventData.domEvent.detail >= 3 ) { | ||
| setSelectionInAncestorElement(); | ||
| } |
There was a problem hiding this comment.
Maybe we should narrow it to just affected cases with widgets? This looks like first we check if in nested editable on FF or Safari and then we do it everywhere.
niegowski
reviewed
Sep 26, 2023
Comment on lines
220
to
227
| // If triple click should select entire paragraph. | ||
| if ( parentElement && | ||
| parentElement.is( 'element' ) && | ||
| !isWidget( parentElement ) && | ||
| domEventData.domEvent.detail >= 3 | ||
| ) { | ||
| this._setSelectionInAncestorElement( element, domEventData ); | ||
| } |
There was a problem hiding this comment.
Why are checking the parent element? I'm not sure what this condition is checking.
niegowski
requested changes
Oct 3, 2023
| /** | ||
| * Selects entire block content, e.g. on triple click it selects entire paragraph. | ||
| */ | ||
| private _selectBlockContent( element: ViewElement ): boolean { |
There was a problem hiding this comment.
This code could be simpler, we could use some existing helper methods. Let's talk about it f2f.
niegowski
approved these changes
Oct 5, 2023
niegowski
deleted the
ck/11130-not-able-to-select-whole-paragraph-with-triple-click
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Suggested merge commit message (convention)
Fix (widget): Triple click on paragraph with widget should select the whole paragraph. Closes #11130.
Additional information
For example – encountered issues, assumptions you had to make, other affected tickets, etc.