Improve cleanup of tests #543
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build c3c4d789-e636-41fe-9523-bbce3022b2a8Details
💛 - Coveralls |
filipsobol
reviewed
Oct 7, 2024
| evt.preventDefault(); | ||
| }; | ||
|
|
||
| window.addEventListener( 'error', handler, { capture: true, once: true } ); |
There was a problem hiding this comment.
To my understanding, this mutes Vitest errors. Would it be possible to use expect().toThrowError() instead?
There was a problem hiding this comment.
It's not working, I tested it
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Suggested merge commit message (convention)
Tests: Add react testing library
cleanupcall before each test to reduce amount of flaky tests. Closes #542Additional information
It looks like error handling in vitest doesn't play well with CKEditor error handling.