-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support foreign key validation #86
base: master
Are you sure you want to change the base?
Conversation
I think the lint failure is kinda incorrect - the lint Action is using Python 3.7.16 (which, as flake8 is saying, did not have the walrus operator); however, the minimum Python version for ckan with Python 3 is 3.8 (as documented here: https://docs.ckan.org/en/2.10/maintaining/installing/install-from-source.html) and Python 3.8 introduced the walrus operator. So I have pushed a small commit to this branch that brings the lint GitHub Action in line with the CKAN-chosen python version 3.8. I have tested locally using act (using the nektos/act-environments-ubuntu:18.04 image) as I don't have the permissions to dispatch on Github. |
@amercader - I appreciate you haven't had chance to review this yet but I was wondering if you could approve the workflow so that I can check my lint action change is fully working? Thanks! |
169a8fc
to
7b517b9
Compare
1645701
to
2ffa7e5
Compare
2ffa7e5
to
b14a37c
Compare
Description
closes #84
Basically, I have rewritten
_validate_table
to use the frictionless Package object, instead of the Resource object.This allows us to then pass in multiple resources and do the following:
ValidationError
Package
object for frictionless framework to utilise during validationTesting
TODO - I am working on these.
Documentation
I have updated the documentation to explain how to use foreign keys. It's fairly brief at the moment but probably in line with other similar parts.