Issue #3475695 by joshua1234511, richardgaunt, sime, toby-wild: civictheme_media_get_variables not returning anything for civictheme_remote_video media type #1316
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshua-salsadigital
added
the
State: Needs review
joshua-salsadigital
force-pushed
the
feature/3475695-media-variables-support
branch
from
afc024b to
f26fc0d
Compare
| 'changed' => civictheme_format_datetime($media->getChangedTime(), 'civictheme_short_date'), | ||
| ]; | ||
|
|
||
| if ($media->bundle() === 'civictheme_remote_video') { |
There was a problem hiding this comment.
We can make it more extensible with:
Suggested change
| if ($media->bundle() === 'civictheme_remote_video') { | |
| if ($media->getSource() instanceof \Drupal\media\Plugin\media\Source\OEmbed) { |
There was a problem hiding this comment.
Also updated to use $source->getMetadata($media, 'url')
and not specific 'field_c_m_oembed_video' field.
Reference
richardgaunt
requested changes
Nov 18, 2024
There was a problem hiding this comment.
@joshua-salsadigital Minor change to make it more extensible
richardgaunt
added
State: Requires more work
… (remote video) in Generic.
joshua-salsadigital
added
State: Needs review
richardgaunt
approved these changes
Dec 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://www.drupal.org/project/civictheme/issues/3475695
Checklist before requesting a review
Issue #123456 by drupal_org_username: Issue titleChangedsection about WHY something was done if this was not a normal implementationChanged
Screenshots