-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CIVIC-1946] Added minimal dependency build system. #1313
base: develop
Are you sure you want to change the base?
Conversation
The 1 second build looks amazing! Could you please explain how will this work with Storybook? |
const DIR_ASSETS_OUT = fullPath('./dist/assets/') | ||
|
||
const COMPONENT_DIR = config.base ? DIR_COMPONENTS_IN : DIR_COMPONENTS_OUT | ||
const STYLE_NAME = config.base ? 'civictheme' : 'styles' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice
|
||
const PATH = __dirname | ||
|
||
const THEME_NAME = PATH.split('/').reverse()[0] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i think adding comments for each variable will really help everyone to understand the purpose
|
||
// --------------------------------------------------------------------------- ASSETS | ||
if (config.assets) { | ||
runCommand(`rsync -a --delete --exclude js --exclude sass ${DIR_ASSETS_IN}/ ${DIR_ASSETS_OUT}/`) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
will this be windows-compatible?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good point
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Currently no, though we could look into the use of robocopy with a -win
flag as an option for Windows developers.
Still looking into how this will work with Storybook (this is one of the reasons why the webpack version still exists). But one option I'm looking at is importing the A developer could run If this could be simplified so a single npm command can run both services, that would be ideal. If there are better alternatives available in storybook to allow custom build system to be configured, we should explore that as well. |
- Simplified the watch - removing unnecessary logic.
4fcdb68
to
dbd6f3c
Compare
https://salsadigital.atlassian.net/browse/CIVIC-1946
Checklist before requesting a review
Issue #123456 by drupal_org_username: Issue title
Changed
section about WHY something was done if this was not a normal implementationChanged
npm run build:new
and watch can be enabled by runningnpm run build:watch:new
.Notes:
Screenshots