WIP Improve performance of Search Kit Activity Search #31529
+6
−69
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
.Overview
This is work in progress on improving hte performance of search kit contact activities tab search on large databases
Before
Tab fails on large dbs
After
Improved performance
@eileenmcnaughton @colemanw this seems to work better but there are two things that I think we still need to work on and i'm a bit stumped
There is another element that I think the current search and the modified version is that for bulk email activities we may hit the group_concat limit and i'm not sure how we can work around that.
I am not sure if i should be setting an output handler on these fields https://github.com/civicrm/civicrm-core/blob/master/Civi/Api4/Service/Spec/Provider/ActivitySpecProvider.php or doing something differently any thoughts would be appreciated