Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dev/core#5449 set NOINDEX on non-public event registration pages #31083

Merged
merged 2 commits into from
Oct 8, 2024

Conversation

eileenmcnaughton
Copy link
Contributor

alternative to #31074

Copy link

civibot bot commented Sep 9, 2024

🤖 Thank you for contributing to CiviCRM! ❤️ We will need to test and review this PR. 👷

Introduction for new contributors...
  • If this is your first PR, an admin will greenlight automated testing with the command ok to test or add to whitelist.
  • A series of tests will automatically run. You can see the results at the bottom of this page (if there are any problems, it will include a link to see what went wrong).
  • A demo site will be built where anyone can try out a version of CiviCRM that includes your changes.
  • If this process needs to be repeated, an admin will issue the command test this please to rerun tests and build a new demo site.
  • Before this PR can be merged, it needs to be reviewed. Please keep in mind that reviewers are volunteers, and their response time can vary from a few hours to a few weeks depending on their availability and their knowledge of this particular part of CiviCRM.
  • A great way to speed up this process is to "trade reviews" with someone - find an open PR that you feel able to review, and leave a comment like "I'm reviewing this now, could you please review mine?" (include a link to yours). You don't have to wait for a response to get started (and you don't have to stop at one!) the more you review, the faster this process goes for everyone 😄
  • To ensure that you are credited properly in the final release notes, please add yourself to contributor-key.yml
  • For more information about contributing, see CONTRIBUTING.md.
Quick links for reviewers...

➡️ Online demo of this PR 🔗

@civibot civibot bot added the master label Sep 9, 2024
Copy link

civibot bot commented Sep 9, 2024

The issue associated with the Pull Request can be viewed at https://lab.civicrm.org/dev/core/-/issues/5449

@magnolia61
Copy link
Contributor

I love this solution. Will test tommorrow (NL time).

While we're at it maybe we should think of all places that should receive the noindex for public facing pages that are configured as non-public

@colemanw
Copy link
Member

@magnolia61 have you had a chance to test this?

@mattwire mattwire merged commit f4a2fdf into civicrm:master Oct 8, 2024
1 check passed
@mattwire
Copy link
Contributor

mattwire commented Oct 8, 2024

Merging as seems like a good generic improvement. @magnolia61 Please test further and continue to iterate.

@eileenmcnaughton eileenmcnaughton deleted the no_index branch October 8, 2024 21:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants