Issue 402: add new community when adding new user - backend #47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Niicck
force-pushed
the
402-community
branch
from
67aa394
to
8341688
Compare
Niicck
commented
Nov 19, 2018
| alter table floods.community alter column abbreviation drop not null; | ||
| alter function floods.new_community(text, text) called on null input; | ||
|
|
||
| alter sequence floods.community_id_seq restart with 9019; |
There was a problem hiding this comment.
@briaguya Do we need to do any futureproofing around new legacy communities? Otherwise it made sense to me to start new community ids where the legacy ones left off.
| new_community_id integer; | ||
| floods_crossing floods.crossing; | ||
| begin | ||
| select id into new_community_id from floods.new_community(community_name, null); |
There was a problem hiding this comment.
@briaguya It seemd like "Abbreviations" for crossings were really only relevant for legacy crossings. Going forward we don't need them for our own new communities, right?
Niicck
force-pushed
the
402-community
branch
from
8341688
to
8d63e16
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to: cityofaustin/ctxfloods#402
Frontend: cityofaustin/ctxfloods#403
When adding a new user, give superadmin the option to create a new community.
Also refactors nodemailer to use OAuth2. Will be helpful to eliminate errors with sending emails from AWS servers. (See: cityofaustin/ctxfloods#401)