Enhancement/tibco driver handling #44
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
svettwer
added
Prio: Medium
TO REVIEW
commissioned
…empty DataSet object
cliffle
approved these changes
Aug 12, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is concerning #29 and softens the JDBC driver contract so that TIBCO Systems are able to work with the driver without limitations.
The issue is caused by the fact that whenever the
next()method is called on aResultSetthe pointer to the data moves one step forward. If the last row of theResultSethas been reached andnext()is called, the pointer to the data moves further and leaves the valid data section. From my knowledge, this is absolutely fine concerning the JDBC contract. Nevertheless, the TIBCO JDBC integration expects that Data is returned whenever theResultSetis accessed. This PR changes theResultSetandDataSetmanagement, so that the pointer cannot leave the valid data section anymore. So no matter how often you call thenext()method when the last row is reached, the data accessed through theResultSetwill stay at the last row.BR,
Sven