Fixed circular hashCode/equals calls

citrusframework · Feb 15, 2019 · 935edb6 · 935edb6
1 parent 38777f8
commit 935edb6
Show file tree

Hide file tree

Showing 5 changed files with 6 additions and 5 deletions.
diff --git a/driver/src/main/java/com/consol/citrus/db/driver/JdbcPreparedStatement.java b/driver/src/main/java/com/consol/citrus/db/driver/JdbcPreparedStatement.java
@@ -356,8 +356,7 @@ public final boolean equals(final Object o) {
                 Objects.equals(parameters, that.parameters)&&
                 Objects.equals(httpClient, that.httpClient) &&
                 Objects.equals(serverUrl, that.serverUrl) &&
-                Objects.equals(connection, that.connection) &&
-                Objects.equals(resultSet, that.resultSet);
+                Objects.equals(connection, that.connection);
     }
 
     @Override

diff --git a/driver/src/main/java/com/consol/citrus/db/driver/JdbcStatement.java b/driver/src/main/java/com/consol/citrus/db/driver/JdbcStatement.java
@@ -385,13 +385,12 @@ public boolean equals(final Object o) {
         final JdbcStatement that = (JdbcStatement) o;
         return Objects.equals(httpClient, that.httpClient) &&
                 Objects.equals(serverUrl, that.serverUrl) &&
-                Objects.equals(connection, that.connection) &&
-                Objects.equals(resultSet, that.resultSet);
+                Objects.equals(connection, that.connection);
     }
 
     @Override
     public int hashCode() {
-        return Objects.hash(httpClient, serverUrl, connection, resultSet);
+        return Objects.hash(httpClient, serverUrl, connection);
     }
 
     @Override

diff --git a/driver/src/test/java/com/consol/citrus/db/driver/JdbcCallableStatementTest.java b/driver/src/test/java/com/consol/citrus/db/driver/JdbcCallableStatementTest.java
@@ -751,6 +751,7 @@ public void equalsContract(){
                         new JdbcResultSet(mock(DataSet.class), mock(JdbcStatement.class)),
                         new JdbcResultSet(mock(DataSet.class), mock(JdbcStatement.class)))
                 .suppress(Warning.NONFINAL_FIELDS)
+                .withIgnoredFields("resultSet")
                 .verify();
     }
 

diff --git a/driver/src/test/java/com/consol/citrus/db/driver/JdbcPreparedStatementTest.java b/driver/src/test/java/com/consol/citrus/db/driver/JdbcPreparedStatementTest.java
@@ -85,6 +85,7 @@ public void equalsContract(){
                         new JdbcResultSet(PowerMockito.mock(DataSet.class), PowerMockito.mock(JdbcStatement.class)))
                 .withRedefinedSuperclass()
                 .suppress(Warning.NONFINAL_FIELDS)
+                .withIgnoredFields("resultSet")
                 .verify();
     }
 }
diff --git a/driver/src/test/java/com/consol/citrus/db/driver/JdbcStatementTest.java b/driver/src/test/java/com/consol/citrus/db/driver/JdbcStatementTest.java
@@ -266,6 +266,7 @@ public void equalsContract(){
                         new JdbcResultSet(PowerMockito.mock(DataSet.class), PowerMockito.mock(JdbcStatement.class)))
                 .withRedefinedSubclass(JdbcPreparedStatement.class)
                 .suppress(Warning.NONFINAL_FIELDS)
+                .withIgnoredFields("resultSet")
                 .verify();
     }
 }