-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tweak(decrapped/native): remove files not supported #2729
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. These are the changes from #2666 with cleaned up commit history.
Isn't removing |
Need to be keep in docs
It might be yeah, removed the ready-to-merge label for now, so that others can re-evaluate. (Given i have no idea how the code gen system works) The |
I'll speak in intern and comeback to a solution here when I'll have one for that specific native. Others should be fine. |
After talking, I think this is the "best" current way to implement the files removed. For hiding the rest used by adhesive, I will work on a different PR. |
Thanks for your contribution, but we don't remove declarations to not break compatibility with existing scripts. |
Goal of this PR
Following natives that are not supported anymore, this PR will remove from the docs.
How is this PR achieving the goal
Remove natives not supported anymore.
This PR applies to the following area(s)
Natives
Successfully tested on
Checklist
Fixes issues
Everything is already closed.