Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

input: Add 'format' property for edtf dates #423

Merged
merged 1 commit into from
Jun 20, 2022
Merged

Conversation

bdarcus
Copy link
Member

@bdarcus bdarcus commented Jun 12, 2022

This allows use of an edtf.js-based validator on the dates.

https://github.com/retorquere/json-schema-edtf

The json schema spec says tools should ignore the property
if they don't know what to do with its value.

Note: season intervals is a non-standard extension available
in edtf.js, which we need.

Close #421

This allow use of an edtf.js-based validator on the dates.

https://github.com/retorquere/json-schema-edtf

The json schema spec says tools should ignore the property
if they don't know what to do with its value.

Close #421
@bdarcus
Copy link
Member Author

bdarcus commented Jun 12, 2022

So is this good @retorquere?

Maybe I just add a link in the documentation https://github.com/retorquere/json-schema-edtf?

One substantive question: adding season intervals is important for us. Does it mean, however, that those aren't valid edtf dates, and that other edt validators will flag them?

@retorquere
Copy link

I welcome seeing the documentation improved - I didn't know what else to put there.

It seems likely to me that other edtf processors would report season intervals as invalid dates, but given that we need these season intervals, the CSL dates would be "EDTF plus season intervals", not "EDTF", and anyone that would choose to treat dates as strictly EDTF in something claiming to be CSL would be out of line with the CSL spec. A clear case of "don't do that" I think.

@bdarcus
Copy link
Member Author

bdarcus commented Jun 12, 2022

I welcome seeing the documentation improved - I didn't know what else to put there.

To be clear, I was meaning here.

@bdarcus bdarcus merged commit 879151d into v1.1 Jun 20, 2022
@bdarcus bdarcus deleted the bdarcus-patch-1 branch June 20, 2022 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants