Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge the following changes from the internal Cisco repository: #5

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

TonySamuels
Copy link

  • Make tar -> tar.gz enhancement backwards compatible
  • Allow propagating from multiple changed dependencies
  • Add channels*

Note that between clippy seeming not to have been run on all code and the automatic update tool to edition 2018, there are several parts of the diffs with no functional changes.

*Channels are a lal feature equivalent to git's branches. The idea behind it is that some dependencies may have multiple branches (e.g. for specific versions, or for different operating systems) and the build target may depend on a specific branch. By adding channels, a new version can be pushed for the dependency for each branch, and they will not conflict. The exact mapping between a channel and git branches (or any other method) is left to the user and tools that work with lal.

- Make tar -> tar.gz enhancement backwards compatible
- Allow propagating from multiple changed dependencies
- Add channels
@clux
Copy link
Contributor

clux commented Apr 10, 2019

Do you need some access to commit in here? I can probably elevate you. Btw, any chances of getting individual commits rather than a large blob?

@TonySamuels
Copy link
Author

I don't believe I have access, but am happy to do it this way anyway.

We've caught a few other changes we want made at the same time, I'll see about redoing this merge with commits once those are complete, but it depends on how much work it would be to strip out any internal files. I expect it won't be a problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants