Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove a few bad characters #39

Merged
merged 2 commits into from
Nov 30, 2018
Merged

Remove a few bad characters #39

merged 2 commits into from
Nov 30, 2018

Conversation

jsf9k
Copy link
Member

@jsf9k jsf9k commented Nov 30, 2018

The latest Censys dump contains a host name that has a few carriage return characters right in the middle of it. This pull request removes such characters.

I recently noticed that we collect a few host names with multiple consecutive dot characters in them. In all such cases, if you remove the repeated dot characters you get an actual domain. This pull request does that as well.

@jsf9k jsf9k added the bug This issue or pull request addresses broken functionality label Nov 30, 2018
@jsf9k jsf9k self-assigned this Nov 30, 2018
@jsf9k jsf9k requested review from KyleEvers and a team November 30, 2018 03:06
Copy link
Contributor

@KyleEvers KyleEvers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@jsf9k jsf9k merged commit 28a2d49 into develop Nov 30, 2018
@jsf9k jsf9k deleted the bugfix/remove_bad_characters branch November 30, 2018 14:00
@konklone
Copy link

Could we handle this better in the gather pipeline in domain-scan, so that projects like this don't have to worry about them?

@jsf9k
Copy link
Member Author

jsf9k commented Dec 1, 2018

@konklone - We certainly could do that. I created 18F/domain-scan#288.

jsf9k pushed a commit that referenced this pull request May 18, 2021
Add markdownlint Configuration Option for MD024
jsf9k pushed a commit that referenced this pull request May 18, 2021
⚠️ CONFLICT! Lineage pull request for: skeleton
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This issue or pull request addresses broken functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants