Skip to content
This repository has been archived by the owner on Sep 22, 2023. It is now read-only.

Disable Report Button when Active or Cooldown #505

Draft
wants to merge 4 commits into
base: develop
Choose a base branch
from

Conversation

dylanj1752
Copy link
Contributor

🗣 Description

Disable the report button when the cycle is currently active or in the cooldown phase. Will allow it to show once in the buffer phase.

💭 Motivation and context

To disable the button when it will not show correct data. To inform the user why the button is disabled when it is in the disabled state.

🧪 Testing

Tested against multiple local subscriptions and cycles.

✅ Pre-approval checklist

  • This PR has an informative and human-readable title.
  • Changes are limited to a single goal - eschew scope creep!
  • All future TODOs are captured in issues, which are referenced
    in code comments.
  • All relevant type-of-change labels have been added.
  • I have read the CONTRIBUTING document.
  • These code changes follow cisagov code standards.
  • All relevant repo and/or project documentation has been updated
    to reflect the changes in this PR.
  • Tests have been added and/or modified to cover the changes in this PR.
  • All new and existing tests pass.

✅ Pre-merge checklist

  • Revert dependencies to default branches.
  • Finalize version.

✅ Post-merge checklist

  • Create a release.

Disable the report button when the cycle is currently active or in the cooldown phase. Will allow it to show once in the buffer phase.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants