Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update HTML report template title (Security Baseline Conformation -> Secure Configuration Baseline) #1362

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

ehaines1
Copy link
Collaborator

@ehaines1 ehaines1 commented Oct 10, 2024

πŸ—£ Description

πŸ’­ Motivation and context

Closes #1298

πŸ§ͺ Testing

βœ… Pre-approval checklist

  • This PR has an informative and human-readable title.
  • PR targets the correct parent branch (e.g., main or release-name) for merge.
  • Changes are limited to a single goal - eschew scope creep!
  • Changes are sized such that they do not touch excessive number of files.
  • All future TODOs are captured in issues, which are referenced in code comments.
  • These code changes follow the ScubaGear content style guide.
  • Related issues these changes resolve are linked preferably via closing keywords.
  • All relevant type-of-change labels added.
  • All relevant project fields are set.
  • All relevant repo and/or project documentation updated to reflect these changes.
  • Unit tests added/updated to cover PowerShell and Rego changes.
  • Functional tests added/updated to cover PowerShell and Rego changes.
  • All relevant functional tests passed.
  • All automated checks (e.g., linting, static analysis, unit/smoke tests) passed.

βœ… Pre-merge checklist

  • PR passed smoke test check.

  • Feature branch has been rebased against changes from parent branch, as needed

    Use Rebase branch button below or use this reference to rebase from the command line.

  • Resolved all merge conflicts on branch

  • Notified merge coordinator that PR is ready for merge via comment mention

βœ… Post-merge checklist

  • Feature branch deleted after merge to clean up repository.
  • Verified that all checks pass on parent branch (e.g., main or release-name) after merge.

@ehaines1 ehaines1 added the enhancement This issue or pull request will add new or improve existing functionality label Oct 10, 2024
@ehaines1 ehaines1 added this to the Kraken milestone Oct 10, 2024
@ehaines1 ehaines1 self-assigned this Oct 10, 2024
@ehaines1 ehaines1 requested review from dagarwal-mitre and removed request for tkol2022 October 10, 2024 15:58
@ehaines1 ehaines1 marked this pull request as ready for review October 11, 2024 15:37
@ehaines1 ehaines1 changed the title change report title to new format Update HTML report template title (Security Baseline Conformation -> Secure Configuration Baseline) Oct 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement This issue or pull request will add new or improve existing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update HTML report template title (Security Baseline Conformation -> Secure Configuration Baseline)
3 participants